[koha-commits] main Koha release repository branch 3.12.x updated. v3.12.04-8-g91211fe

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.12.x has been updated
       via  91211febd5606e4c3713f235817ec0f4a46128c9 (commit)
       via  3d05ea27a7237006d1256df9b476f4886b027233 (commit)
      from  6df54fd2fa2e33166c5c6e24b5aabf8299ed5ef9 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 91211febd5606e4c3713f235817ec0f4a46128c9
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Tue Jul 9 11:48:23 2013 +0200

    Bug 2394: Use syspref canreservefromotherbranches in CanItemBeReserved
    
    If IndependentBranches is ON, patrons are not allowed to place
    hold requests on items whose owning library is different from
    the patron's home library, *unless* the canreservefromotherbranches
    system preference is also ON.
    
    The patch implements the intended behavior; without it, IndependentBranches
    and canreservefromotherbranches were not consulted during the
    item holdability check.
    
    To test:
    
    [1] Have IndependentBranches ON and canreservefromotherbranches
        OFF.  Make sure that the circulation rules are set up to
        permit patrons to place hold requests in general.
    [2] In the OPAC, log in as a patron from library A, and try placing
        a hold on an item from library B.  The patron will be able to
        place the request.
    [3] Cancel the request.
    [4] Apply the patch.
    [5] Try placing the same hold request.  This time, the request should
        be forbidden.
    [6] Turn on canreservefromotherbranches.
    [7] Try placing the hold request.  This time, it should go through.
    [8] Cancel the request.
    [9] Turn off IndependentBranches.
    [10] Try placing the hold request and verify that it is permitted.
    [10]
    
    Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 2cbc47a871efc60ae663ecfedf59ec77dda718f4)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    Works as expected.
    Note: on my tests i first forgot to enable AllowOnShelfHolds to get this working. It is not mentioned on the test description.

commit 3d05ea27a7237006d1256df9b476f4886b027233
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Fri Aug 9 17:40:54 2013 +0000

    bug 2394: regression test for canreservefromotherbranches
    
    If IndependentBranches is ON and canreservefromotherbranches is OFF,
    a patron is not permittedo to request an item whose homebranch (i.e.,
    owner of the item) is different from the patron's own library.
    However, if canreservefromotherbranches is turned ON, the patron can
    create such hold requests.
    
    Note that canreservefromotherbranches has no effect if
    IndependentBranches is OFF.
    
    To test, run prove -v t/db_dependent/Holds.t.  Without the bugfix
    patch for bug 2394, the last two tests should fail.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 23e302071efabd824f0a6c69bc68dee4cfc13e5b)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    The Holds.t file was introduced by 9394 which refactors several lines of code and thus i'm not cherry-picking in the stable branch.
    I'm just cherry-picking Galen's regression tests.

-----------------------------------------------------------------------

Summary of changes:
 C4/Reserves.pm         |   17 ++++++-
 t/db_dependent/Holds.t |  103 ++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 117 insertions(+), 3 deletions(-)
 create mode 100755 t/db_dependent/Holds.t


hooks/post-receive
-- 
main Koha release repository