[koha-commits] main Koha release repository branch master updated. v3.12.00-beta1-1100-gb54e33c

Git repo owner gitmaster at git.koha-community.org
Mon Sep 16 17:27:12 CEST 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  b54e33c1f62e4aa2c7e46a7fafa445f33f570326 (commit)
      from  4f9ee9a6b8d1c84d4ff9894998f0f9a8904201fa (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit b54e33c1f62e4aa2c7e46a7fafa445f33f570326
Author: Magnus Enger <magnus at enger.priv.no>
Date:   Sat Aug 31 15:33:24 2013 +0200

    Bug 10810 - Fix synopsis for -html option to overdue_notices.pl
    
    The synopsis for the -html option used to be:
      -html <filename> Output html to file
    but the argument to this option should actually be a directory,
    not a filename. This patch fixes the synopsis.
    
    To test:
    - Run perldoc misc/cronjobs/overdue_notices.pl
    - Check that the synopsis is as shown above
    - Apply this patch
    - Run perldoc misc/cronjobs/overdue_notices.pl
    - Check that
      - the synopsis asks for a directory, not a filename
      - that the description of the -html option further down in the
        perldoc now mentions the filename that the HTML file will be
        created with.
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Works as described. No koha-qa errors.
    
    If feeded with a filename -html option fails with many messages like
    print() on closed filehandle $html_fh at misc/cronjobs/overdue_notices.pl line 384.
    Perhaps it could be improved, but that was the old behavior.
    
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Improves documentation, no negative side effects found.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 misc/cronjobs/overdue_notices.pl |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list