[koha-commits] main Koha release repository branch master updated. v3.12.00-beta1-1119-g8e0c21c

Git repo owner gitmaster at git.koha-community.org
Mon Sep 16 21:03:25 CEST 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  8e0c21cf38b930c207d2efab4a3b55e359b95b89 (commit)
       via  ddb67e32377185df371c85172308be882968b14f (commit)
       via  995f4b6ecb504e1648816b0841e90efb814f25c7 (commit)
      from  fc84903dfb73212029466764005bb53e5089acc8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 8e0c21cf38b930c207d2efab4a3b55e359b95b89
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date:   Thu Sep 12 07:36:24 2013 +0200

    Bug 10667: Follow up - prevent t/00-load from failing
    
    To test:
    - Apply first 2 patches for unit tests and changes to Services.pm
    - Turn off mysql
    - Run t/00-load.t
    - Verify that the test fails.
    - Apply this third patch.
    - Run t/00-load.t again.
    - Verify this time it passes.
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Comment: Work well, no koha-qa errors.
    
    Without third patch and mysql down, test fails,
    with third patch it succeed.
    Signed-off-by: Mason James <mtj at kohaaloha.com>
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit ddb67e32377185df371c85172308be882968b14f
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date:   Sun Sep 8 21:42:04 2013 +0200

    Bug 10667: Allow authentication with cardnumber for ILS-DI
    
    Test authentication via ILS-DI:
    - with userid and password
    - with userid and wrong password
    - with cardnumber and password
    - with cardnumber and wrong password
    ...
    
    Before the patch only userid will authenticate the patron.
    After the patch was applied, userid and cardnumber will work.
    
    To test:
    - Run t/db_dependent/ILSDI_Services.t - all tests should pass.
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    No koha-qa errors
    
    Test:
    Enable ISL-DI
    access opac with /cgi-bin/koha/ilsdi.pl?service=AuthenticatePatron&username=XXX&password=YYY
    With userid/cardnumber & password returns borrowernumber
    With userid/cardnumber & wrong password returns PatronNotFound
    Signed-off-by: Mason James <mtj at kohaaloha.com>
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 995f4b6ecb504e1648816b0841e90efb814f25c7
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date:   Sun Sep 8 21:34:37 2013 +0200

    Bug 10667: Add unit tests for ILSDI::Services::AuthenticatePatron
    
    This patch adds unit tests for Authenticate patron.
    
    To test:
    - Run perl t/db_dependent/ILSDI_Services.t
    - Verify all tests pass
    
    Note: there are some tests marked as TODO.
    
    Rewriting AuthenticatePatron to make cardnumber and userid
    work for authenticating a patron will be implemented in the
    next patch. Tests related to this are currently showing as
    'not ok', but are still passing.
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    No koha-qa errors
    With both patches applied, all test pass.
    Signed-off-by: Mason James <mtj at kohaaloha.com>
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/ILSDI/Services.pm                         |   25 +++----
 koha-tmpl/opac-tmpl/prog/en/modules/ilsdi.tt |    2 +-
 t/00-load.t                                  |    1 +
 t/db_dependent/ILSDI_Services.t              |   92 ++++++++++++++++++++++++++
 4 files changed, 105 insertions(+), 15 deletions(-)
 create mode 100644 t/db_dependent/ILSDI_Services.t


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list