[koha-commits] main Koha release repository branch master updated. v3.12.00-beta1-1129-g88d1e14
Git repo owner
gitmaster at git.koha-community.org
Tue Sep 17 17:16:03 CEST 2013
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 88d1e1472857a3996e8704c738e89acd2294369d (commit)
via 2f9cf0d29540f64905cb8dce9dfae88ef0962ef7 (commit)
via 30c5d8ddc041a56014965f32134a0e4ab20219bd (commit)
via 013726fda2f52fe6226402dbfd6fb941d5923778 (commit)
via 62d1f73448fd6f93637569f4c638e1890e929e1a (commit)
via 0005f6bad36319e11a1b0c561403e75758a803af (commit)
from 85a8df4ca12d9bad0079618353ce8dcbf14da987 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 88d1e1472857a3996e8704c738e89acd2294369d
Author: Galen Charlton <gmc at esilibrary.com>
Date: Tue Sep 17 15:10:11 2013 +0000
Bug 7639: DBRev 3.13.00.020
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 2f9cf0d29540f64905cb8dce9dfae88ef0962ef7
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon Aug 19 08:01:13 2013 -0400
Bug 7639: (follow-up) add Unit Tests
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
All tests and QA script pass.
I fixed a redundant 'my' that the QA script pointed out.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 30c5d8ddc041a56014965f32134a0e4ab20219bd
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon Jul 15 08:41:51 2013 -0400
Bug 7639: QA Followup - Fix update description
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
With these patches we now have 3 preferences that deal with
fines/fees and lost items:
Replacement price
- On marking lost: WhenLostChargeReplacementFee
- On return: RefundLostItemFeeOnReturn (preexisting)
Overdue fines
- On marking lost: WhenLostForgiveFine
System preferences work according to their description.
Further notes:
- Patches pass all tests and QA script.
- LostItem is changed and needs unit tests.
All occurrences of LostItem have been changed.
- Database update is ok. I had to fix the sysprefs.sql
file that has been recently rewritten and alphabetized.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 013726fda2f52fe6226402dbfd6fb941d5923778
Author: Paul Poulain <paul.poulain at biblibre.com>
Date: Thu Mar 21 11:24:38 2013 +0100
Bug 7639: tiny QA follow-up
no need to create a variable just to call to send it as parameter the line after
Signed off by: Alex Hatley <alexh at cctexas.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 62d1f73448fd6f93637569f4c638e1890e929e1a
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Oct 23 08:03:16 2012 -0400
Bug 7639 - system preference to forgive fines on lost items - QA Followup
Test Plan:
1) Apply the patch
2) Run updatedatabase.pl
3) Set WhenLostForgiveFine to Forgive & WhenLostChargeReplacementFee to Charge
4) Issue an item to a borrower, then set to lost from catalogue/moredetail.pl
5) Observe the replacement fee has been charged
6) Return the item
7) Observe the charged fee has been forgiven
8) Set WhenLostForgiveFine to Don't Forgive
9) Repeat 4-6
10) Observe the charged fee has not been forgiven
11) Set WhenLostChargeReplacementFee to Don't Charge
12) Repeat 4
13) Observe that a fee was not charged
Signed-off-by: Alex Hatley <alexh at cctexas.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 0005f6bad36319e11a1b0c561403e75758a803af
Author: Meenakshi.R <meenakshi.r at osslabs.biz>
Date: Fri Jul 6 10:42:50 2012 +0530
Bug 7639: add option to forgive overdue fines when declaring items lost
This patch adds functionality to forgive overdue fine when an item is
set to lost status. Fines are forgiven only when the syspref
WhenLostForgiveFine is set to yes. Item can be set to lost status from:
- catalogue/moredetail.pl
- cataloguing/additem.pl
- tools/batchMod.pl
- misc/cronjobs/longoverdue.pl
Changed subroutine C4::Circulation::LostItem to forgive fines on the
item depending on the value of syspref WhenLostForgiveFine. This
routine is currently used to return an item and charge a replacement
cost.
Also added a new syspref in C4::Circulation::LostItem -
WhenLostChargeReplacementFee. The replacement fee will now be charged
only if this syspref is set to yes. The default value of the
WhenLostChargeReplacementFee is yes, meaning that current behavior
will not change during upgrade.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Alex Hatley <alexh at cctexas.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Testing notes on last patch in series.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Circulation.pm | 18 ++++--
catalogue/updateitem.pl | 2 +-
cataloguing/additem.pl | 10 +++
installer/data/mysql/sysprefs.sql | 2 +
installer/data/mysql/updatedatabase.pl | 9 +++
.../en/modules/admin/preferences/circulation.pref | 12 ++++
kohaversion.pl | 2 +-
misc/cronjobs/longoverdue.pl | 2 +-
t/db_dependent/Circulation.t | 70 ++++++++++++++++----
tools/batchMod.pl | 2 +-
10 files changed, 107 insertions(+), 22 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list