[koha-commits] main Koha release repository branch master updated. v3.12.00-beta1-1134-gf072cbd

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  f072cbdf9bf35a44364c5374b8284c0583f4e262 (commit)
       via  5d8ad739293ef8cf22a808404e52a9c74275aaf0 (commit)
       via  9ab593440b6d2b1f9c417631a4cf5cabcf1a0032 (commit)
       via  e191bb02bfda7f17ae8b4f681314c51d2e7e6b92 (commit)
      from  dcbe50cde84505198dffbd1a65d998287f0902dc (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit f072cbdf9bf35a44364c5374b8284c0583f4e262
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Fri Sep 13 06:47:15 2013 -0400

    Bug 10876: Fix opac-MARCdetail.pl displaying items that are meant to be hidden
    
    When OpacHiddenItems is used to hide some, but not all of the
    items for a biblio, then the opac-MARCdetail page displayed
    all the items, rather than just the ones intended to be visible.
    
    By determining the tag and subtag for items.itemnumber, the
    loop which builds the big array can be filtered to exclude
    records that should be hidden.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    Works as expected, passes koha-qa also.
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 5d8ad739293ef8cf22a808404e52a9c74275aaf0
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Mon Sep 16 15:29:04 2013 -0300

    Bug 10872: UT for GetHiddenItemnumbers and POD fix
    
    This patch adds several unit tests for GetHiddenItemnumbers and fixes the POD for it.
    It also wraps the tests for rollback, modernizes and adds a license text to it.
    
    Sponsored-by: Universidad Nacional de Cordoba
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 9ab593440b6d2b1f9c417631a4cf5cabcf1a0032
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Tue Sep 10 16:19:58 2013 -0400

    Bug 10872 - C4::Items GetHiddenItems fix and optimization
    
    There should be a:
    "require YAML;"
    or
    "use YAML qw/Load/;"
    
    as the GetHiddenItems routine has a reference to YAML::Load.
    
    This was discovered while adding a GetHiddenItems() call into
    opac/opac-MARCdetail.pl. I believe this problem dates back to
    bug 6488 or bug 5984.
    
    I also added an optimization to GetHiddenItems to prevent
    processing if there is nothing in the system preference. Test
    by searching for a biblio which has some or all of its items
    hidden.
    
    Signed-off-by: Mason James <mtj at kohaaloha.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Maybe
      return () unless $yaml =~ /\S/;
    or
      return () if $yaml =~ /^\s*$/;
    would have been easier to read.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit e191bb02bfda7f17ae8b4f681314c51d2e7e6b92
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Thu Jul 11 23:13:42 2013 -0400

    Bug 10584 - Hide OPAC biblio details if all items are hidden
    
    If there are items for a given biblio number, and they are all
    hidden, then biblio needs to be hidden. If the biblio needs to
    be hidden, it immediately redirects to a 404.pl page, just as
    if the biblionumber does not exist.
    
    Arrays used to represent all the items were relocated and used,
    added if they didn't exist. Arrays representing the hidden
    items were relocated and used if they existed, added if they
    didn't exist.
    
    Upon debugging the opac-MARCdetail.pl modification, it was
    discovered the reason getHiddenItems was failing was because
    'use YAML qw/Load/;' was not mentioned in C4::Items, and other
    libraries were triggering the loading of YAML to compensate
    for opac-detail.pl and opac-ISBDdetail.pl files.
    
    Signed-off-by: Mason James <mtj at kohaaloha.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Items.pm             |   10 ++-
 opac/opac-ISBDdetail.pl |   12 +++-
 opac/opac-MARCdetail.pl |   22 +++++++
 opac/opac-detail.pl     |   21 +++----
 t/db_dependent/Items.t  |  158 ++++++++++++++++++++++++++++++++++++++---------
 5 files changed, 176 insertions(+), 47 deletions(-)


hooks/post-receive
-- 
main Koha release repository