[koha-commits] main Koha release repository branch master updated. v3.12.00-beta1-1144-g72479fe
Git repo owner
gitmaster at git.koha-community.org
Wed Sep 18 19:11:16 CEST 2013
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 72479fec404ebf446f53a1c290ac10139e65d418 (commit)
via f4a30cc68bb633b6a990f87205f76728e27ae985 (commit)
via 2cd9ff8e3eb6bf1625c9fe50d56815df9f8c02ab (commit)
via 3086788b26ef8b04e4abbf2cdf94c60ef120cf02 (commit)
from 304b8d7de3c75c0002528bcd4b142ed3340d452a (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 72479fec404ebf446f53a1c290ac10139e65d418
Author: Galen Charlton <gmc at esilibrary.com>
Date: Wed Sep 18 17:23:44 2013 +0000
Bug 10601: (follow-up) improvements to ->set() and ->get()
This patch improves the POD for C4::BackgroundJob->get(). It also
fixes ->set() so that it cannot scribble over values that are properly
internal to the object.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit f4a30cc68bb633b6a990f87205f76728e27ae985
Author: Galen Charlton <gmc at esilibrary.com>
Date: Wed Sep 18 17:21:47 2013 +0000
Bug 10601: (follow-up) unit tests for new ->set() and ->get()
This adds unit test for the new methods in C4::BackgroundJob. One
of the tests verfies that setting extra values does not scribble over
data that is mean to be internal to the C4::BackgroundJob object.
To test:
Verify that prove -v t/db_dependent/BackgroundJob.t passes.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 2cd9ff8e3eb6bf1625c9fe50d56815df9f8c02ab
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Aug 16 10:18:15 2013 -0400
Bug 10601 [QA Followup] fix POD error
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 3086788b26ef8b04e4abbf2cdf94c60ef120cf02
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Tue Jul 16 17:28:43 2013 +0200
Bug 10601: Add a counter on batch items modifications
After executing a batch items modifications, a dialog is displayed above
the result table. It contains the number of items (and total fields)
which has been modified.
Note that items that are selected for modification but which do not
end up actually be changed are not reported in the final counts.
This patch adds two methiods to C4::BackgroundJob, ->set() and ->get(),
that allow background jobs to pass arbitrary data back to the client.
Test plan:
1/ Go to tools/batchMod.pl
2/ Enter a barcodes list
3/ Check/uncheck items and fill some values to apply
4/ Save
5/ The table summary will be displayed with a dialog box on top:
XX item(s) modified (with YY fields modified)
Check that XX and YY correspond with what you expected.
Signed-off-by: Liz Rea <liz at catalyst.net.nz>
batch modification still seems to work correctly, with the helpful addition of the counter. Thanks!
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
-----------------------------------------------------------------------
Summary of changes:
C4/BackgroundJob.pm | 40 +++++++++++
.../prog/en/modules/tools/batchMod-edit.tt | 9 ++-
t/db_dependent/BackgroundJob.t | 8 ++-
tools/batchMod.pl | 70 +++++++++++++-------
4 files changed, 102 insertions(+), 25 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list