[koha-commits] main Koha release repository branch master updated. v3.12.00-beta1-1156-gfe36280

Git repo owner gitmaster at git.koha-community.org
Sat Sep 21 21:07:37 CEST 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  fe3628070a7affddb691ee589ec0e63639d0a36a (commit)
       via  1dc7d421bc87e3cf027161b08fbb44875c778f49 (commit)
       via  ab362b93a710bddcd385a6a468af6ff682673367 (commit)
      from  9bd3a44944e6a0cb7920c3c53a88c11a8986b146 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit fe3628070a7affddb691ee589ec0e63639d0a36a
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Sat Sep 21 19:16:56 2013 +0000

    Bug 7813: (follow-up) use descriptive text for delete link
    
    This patch replaces the "times" symbol for the local cover image
    deletion link with more descriptive text.  This was done because
    the original "X" was small, is not necessarily going to be universally
    understood to signify the deletion action, and because "×"
    does not give much context to translators.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 1dc7d421bc87e3cf027161b08fbb44875c778f49
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Fri Sep 20 13:06:48 2013 +0200

    Bug 7813: (follow-up) improvements for deleting local cover images
    
    This patch:
    - displays a js alert if a problem occurred on deleting the
      image on the server.
    - adds a class for the new span (in order to avoid future problem, if
      someone adds a new span).
    - adds a title for the [X] link.
    - deal with the upload_local_cover_images permission (don't display the
      delete link if the logged in user does not have it).
    - changes the license version.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    I like the ehancements to the original patch and work as expected.
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit ab362b93a710bddcd385a6a468af6ff682673367
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Fri Aug 30 16:43:30 2013 -0300

    Bug 7813: Ability to delete local cover images
    
    This patch adds the ability to delete local cover images from the
    detail page. It adds an 'X' button to trigger the deletion. It occurs
    using a new SVC script called cover_images that accepts the following
    parameters:
    
     - action
     - biblionumber (used for checking imagenumber validity)
     - imagenumber (repeatable)
    
    It then deletes all valid images passed and returns a JSON object
    containing the imagenumbers and the deletion status (1/0). The operation
    is triggered using jQuery.ajax, and with the response the corresponding
    images get deleted.
    
    Note: currently one image is deleted at a time, but the code is there to
    be used.
    
    To test:
    - Open the detail page fr a biblionumber containing one or more cover
      images, go to its images tab.
    - Apply the patch, reload the page, go to the images tab.
    - Thumbnails should look better than before ;-)
    - An 'X' button should show below each cover.
    - Clicking the 'X' button should trigger an alert message asking for
      confirmation.
     a) Cancel: nothing happens, reload the page and check nothing got
        deleted.
     b) Accept: the deleted image should be gone, reload the page to check
        it doesn't exist anymore and is not a browser/DOM manipulation trick.
    - Signoff
    
    Note: check having more cover images than those that fit the width and
    see it wraps fine.
    
    P.S. I chose not to implement every possible action on the svc script, but
    another bug could be filled for more improvements.
    
    Sponsored-by: Universidad Nacional de Cordoba
    Signed-off-by: David Cook <dcook at prosentient.com.au>
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 .../intranet-tmpl/prog/en/css/staff-global.css     |    4 +
 .../prog/en/modules/catalogue/detail.tt            |   51 +++++++++++--
 svc/cover_images                                   |   76 ++++++++++++++++++++
 3 files changed, 124 insertions(+), 7 deletions(-)
 create mode 100755 svc/cover_images


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list