[koha-commits] main Koha release repository branch master updated. v3.14.00-720-gc16cadf
Git repo owner
gitmaster at git.koha-community.org
Fri Apr 11 19:40:42 CEST 2014
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via c16cadf21656e6c1796c7eac28db33ead02cf59d (commit)
via 2aafa78f08c60797e47cbe790cef1f1899a5297d (commit)
via db3d4a0d7d2b97a021be1464a99b8084c31b62cb (commit)
via 1226f901cef989915ee68e7ac7d1b1acf9fba91c (commit)
via e5ab2203745d7c70e1c4d2f54cea967710a88b96 (commit)
from 9132f9befb36f32fc35a511c3829c224b42893bf (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit c16cadf21656e6c1796c7eac28db33ead02cf59d
Author: Galen Charlton <gmc at esilibrary.com>
Date: Fri Apr 11 17:51:50 2014 +0000
Bug 11563: (follow-up) remove some tabs
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 2aafa78f08c60797e47cbe790cef1f1899a5297d
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Tue Mar 25 09:30:14 2014 +0100
Bug 11563: (follow-up) improve selector for adding noEnterSubmit to select elements
Test plan:
To test on modified pages:
- Press enter when cursor is on input or select and verify the form is not
submitted.
Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit db3d4a0d7d2b97a021be1464a99b8084c31b62cb
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Mar 7 09:05:31 2014 -0500
Bug 11563: (follow-up) add noEnterSubmit class to pulldowns
When using Chrome on Mac OS X, form submits are triggered by hitting
enter when focused on a select. This is not an issue with any other
combination of browser and operating system that I am aware of.
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 1226f901cef989915ee68e7ac7d1b1acf9fba91c
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Wed Feb 26 12:51:11 2014 -0500
Bug 11563: (follow-up) change .live() to .on()
The jquery event handler .live() has been deprecated. It is recommended
that .on() be used instead.
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit e5ab2203745d7c70e1c4d2f54cea967710a88b96
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Tue Feb 25 12:13:13 2014 +0100
Bug 11563: restore preventing the enter key from submitting several forms
Several forms that take patron or item barcodes as input stopped
preventing the enter key (which is often sent by barcode scanners)
from submitting the form.
The code binding the CSS class noEnterSubmit to the handler preventing
submission when hitting the enter key was no longer triggered. This is
because this class is added using JavaScript in $(document).ready() and
the keypress event listerning is also set using $(document).ready().
This patch corrects by using JQuery live() with will set event handlers
for HTML generated with JavaScript.
Also sets noEnterSubmit to use the checkEnter(e) function, as that has
broader browser compatibility. Also corrects a small bug, for IE,
window.event must be used, not event alone.
Test plan :
- Flush browser cache (Crtl+F5) to update js files
- Go to patron creation : members/memberentrygen.tt
- Type a text in all mandatory inputs
- Type some caracters in a non mandatory input
- Press Enter key
=> Without patch : the form is submitted
=> With patch : the form is not submitted
- Try to set several lines in a textarea
=> It works (checks that in this case enter key is allowed)
- Test other pages usign noEnterSubmit class :
cataloguing/additem.tt
course_reserves/course.tt
members/mancredit.tt
members/maninvoice.tt
patron_lists/list.tt
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Works as described, tested in Firefox and Chromium.
Passes tests and QA script.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
-----------------------------------------------------------------------
Summary of changes:
koha-tmpl/intranet-tmpl/prog/en/js/staff-global.js | 32 ++++++++++----------
.../prog/en/modules/cataloguing/additem.tt | 2 +-
.../prog/en/modules/members/mancredit.tt | 2 +-
.../prog/en/modules/members/maninvoice.tt | 2 +-
.../prog/en/modules/members/memberentrygen.tt | 2 +-
5 files changed, 20 insertions(+), 20 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list