[koha-commits] main Koha release repository branch master updated. v3.14.00-766-g47a9afc
Git repo owner
gitmaster at git.koha-community.org
Fri Apr 18 22:38:09 CEST 2014
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 47a9afcb7ecedc805550f46e6373b9a8c8615bdc (commit)
from dc6d8a2199f79e36839a2769994883e04b61cb67 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 47a9afcb7ecedc805550f46e6373b9a8c8615bdc
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Fri Mar 28 14:38:25 2014 +0100
Bug 12003: Do not calculate next pubdate for irregular subscriptions
Show 'Unknown' when planneddate and publisheddate cannot be calculated
Also fixes SQL query in misc/cronjobs/serialsUpdate.pl that was still
using "periodicity != 32" to exclude irregular subscriptions from
results
Test plan:
1) Create a subscription in the serials module. Make sure to choose:
Frequency = Irregular
2) Test the prediction pattern, first publication date is set to
"First issue publication date" field, others will show as
'unknown'
3) Save the subscription
4) Check the created issue - it will show a published date and a
planned date (same as "First issue publication date" field)
5) Receive the issue and check the next generated issue, planned
date and published date should show as 'Unknown'
6) Generate a next issue, planned date and published date should
also show as 'Unknown'
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Work as described following test plan.
No koha-qa errors
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes all tests and QA script.
Also tested:
- multi receiving generates mulitple issues without dates - 'unknown'
- staff detail page shows the dates empty, which is fine
- OPAC detail page shows the dates empty, which is fine
- serial collection page shows 'unknown' and those issues appear
on the 'manage' tab, as they did in the past
- Editing the issue from the serial collection page leaves the
date fields empty.
- Receving the issue, setting the status to 'Arrived' the Expected on
date is set to 'today' automatically. Date published has to be
entered manually (maybe something we could improve later
- subscription detail > issues tab shows Uknown.
- t/db_dependent/Serials/GetNextDate.t pass.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Serials.pm | 17 ++++++-----------
.../prog/en/modules/serials/serials-collection.tt | 16 ++++++++++++++--
.../prog/en/modules/serials/subscription-detail.tt | 12 ++++++++++--
misc/cronjobs/serialsUpdate.pl | 4 +++-
serials/showpredictionpattern.pl | 4 ++--
t/db_dependent/Serials/GetNextDate.t | 18 ++++++++++++------
6 files changed, 47 insertions(+), 24 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list