[koha-commits] main Koha release repository branch master updated. v3.14.00-818-gc5f8bf2

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  c5f8bf244b9db2e3279774435ae75f7c4b4ab68a (commit)
       via  774483772b2a7ff8ebdb8a9aeac82881e7c858cf (commit)
       via  c4900dc448aa029749ab27f98b59d1be6eb8bb14 (commit)
       via  da7dd4ed8c2462597712a11b0a018db87b1fef87 (commit)
      from  97bf5f258a53e7d4fd89b29dc57f74012e9421c4 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c5f8bf244b9db2e3279774435ae75f7c4b4ab68a
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Thu Mar 20 11:14:58 2014 +0100

    Bug 11912: (follow-up) Use the common way to mock syspref
    
    t::lib::Mocks::mock_preference provides a simple way to mock syspref.
    
    Test plan:
    Verify that t/db_dependent/Biblio.t returns green.
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 774483772b2a7ff8ebdb8a9aeac82881e7c858cf
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Mon Mar 10 11:52:19 2014 -0300

    Bug 11912: (refactoring followup) make GetMarcISBN implement its advertised API
    
    The current implementation of GetMarcISBN contradicts the documented API.
    It currently returns an array of hashes with only one key (marcisbn)
    which doesn't add any value to it.
    
    I chose to fix GetMarcISBN to honour the API instead of changing thex
     docs, because it seems a really silly change.
    
    To test:
    - Run:
      prove t/db_dependent/Biblio.t
    => SUCCESS
    - catalogue/detail.pl should correctly show ISBNs.
    - opac/opac-detail.pl should correctly show ISBNs in both prog and bootstrap.
    - opac-opac-sendshelf.pl should correctly show ISBNs in the email.
    
    Sponsored-by: Universidad Nacional de Cordoba
    Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit c4900dc448aa029749ab27f98b59d1be6eb8bb14
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Sun Mar 9 18:39:11 2014 -0300

    Bug 11912: fix problem where GetMarcISBN wrongly prepends a space to ISBNs
    
    This patch makes the logic inside GetMarcISBN simpler and
    fixes the issue.
    
    To test:
    - Run the regression tests:
      prove -v t/db_dependent/Biblio.t
    => FAIL
    - Apply the patch
    - Run:
      prove -v t/db_dependent/Biblio.t
    => SUCCESS
    - Verify that opac-detail.pl and catalogue/detail.pl look as usual regarding ISBN
    - Sign off
    
    Sponsored-by: Universidad Nacional de Cordoba
    Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit da7dd4ed8c2462597712a11b0a018db87b1fef87
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Sun Mar 9 17:21:48 2014 -0300

    Bug 11912: (regression tests) GetMarcISBN wrongly prepends a space to ISBNs
    
    This patch makes the tests run in both MARC21 and UNIMARC contexts.
    It previously run only for MARC21. It mocks what needs to be mocked.
    
    To test, run
     - prove t/db_dependent/Biblio.t
    => Notice the first ISBN has a space in front of it and those tests fails.
    
    Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Biblio.pm                                       |   17 +-
 .../prog/en/modules/catalogue/detail.tt            |    2 +-
 .../opac-tmpl/bootstrap/en/modules/opac-detail.tt  |    2 +-
 .../bootstrap/en/modules/opac-sendshelf.tt         |    2 +-
 koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt |    2 +-
 .../opac-tmpl/prog/en/modules/opac-sendshelf.tt    |    2 +-
 t/db_dependent/Biblio.t                            |  339 ++++++++++++++------
 7 files changed, 249 insertions(+), 117 deletions(-)


hooks/post-receive
-- 
main Koha release repository