[koha-commits] main Koha release repository branch master updated. v3.14.00-899-g2a7e715
Git repo owner
gitmaster at git.koha-community.org
Thu Apr 24 14:27:04 CEST 2014
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 2a7e71554b534f8d79cdbdc9552bc78bba9c4408 (commit)
via ee4e4917eb3fad95680c63aee025a3e94ba898c0 (commit)
via acd8a10251da42d44c262cb63ee2b585352a860a (commit)
via 83093abe89c7074afa3ff5c72e8ec881a58151f6 (commit)
via 33cc81bbc37046d9a38ff3d4b64f546e5e8f77b8 (commit)
from 45ce7431d42cd470d7f7326d8935333014b1f62c (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 2a7e71554b534f8d79cdbdc9552bc78bba9c4408
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Thu Mar 13 11:30:15 2014 -0300
Bug 10942: (QA followup) make warnings to to STDERR
As noted by Robin, STDOUT is used by the script to communicate with
debconf and, hence, the warning messages should be directed to STDERR.
This patch does that. To test:
- Set AUTOMATIC_TRANSLATIONS_UPDATE="no" so the warning normally shows
- Redirect STDOUT to /dev/null:
dpkg -i koha-common...deb > /dev/null
=> Warning message doesn't show (i.e. it is sent to STDOUT)
- Apply the patch, rebuild package
- Redirect STDOUT to /dev/null:
dpkg -i koha-common...deb > /dev/null
=> Warning message shows (i.e. is correctly sent to STDERR)
- Redirect STDERR to /dev/null:
dpkg -i koha-common...deb 2> /dev/null
=> Warning message doesn't show
- Verify that previous tests pass
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit ee4e4917eb3fad95680c63aee025a3e94ba898c0
Author: Robin Sheat <robin at catalyst.net.nz>
Date: Wed Mar 12 17:24:36 2014 +1300
Bug 10942: (follow-up) debconfing the update option
This causes a question to be asked at installation time as to whether
translations should be updated or not. The answer is written to the
config file, and stored in debconf. Effort is taken to ensure that if
the admin changes the config file, the update will be picked up and
reflected in debconf (i.e. that the admin's decision is always the
correct one.)
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Fixed two typos that made it fail and it worked like a charm.
Tested like this:
- Install the package
=> no errors, the file is created, defaults to 'yes'
- Install a language (koha-translate --install es-ES)
- Re-install the package (simulating an upgrade)
=> es-ES gets updated
- Set preference to 'no'
- Re-install
=> es-ES doesn't get updated, the warning is printed correctly
- Installed a second language (koha-translate --install pt-BR)
- did all the tests again
=> Success
Note: on master there are obvious template translation warnings.
A copy of the generated package can be grabbed from:
http://es.koha-community.org/koha-common_3.15+20140312172225.af7c0a23_all.deb
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit acd8a10251da42d44c262cb63ee2b585352a860a
Author: Galen Charlton <gmc at esilibrary.com>
Date: Wed Mar 12 02:07:53 2014 +0000
Bug 10942: (follow-up) make AUTOMATIC_TRANSLATIONS_UPDATE default to yes
This patch makes AUTOMATIC_TRANSLATIONS_UPDATE default to yes,
meaning that package upgrades will update the translations by
default. This seems definitely sensible for new installations,
but as there are some older installations that may be in the
habit directly editing generated translated templates, it's
less clear whether this is a good idea for upgrades.
This patch is intentionally separate, and can be ignored if
the consensus swings towards having AUTOMATIC_TRANSLATIONS_UPDATE
be off even for new installations or if somebody counter-patches
with adding debconf support.
To test:
- As with the previous patches in the series, except that the
translations would be automatically updated upon installing
the new package.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Robin Sheat <robin at catalyst.net.nz>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 83093abe89c7074afa3ff5c72e8ec881a58151f6
Author: Galen Charlton <gmc at esilibrary.com>
Date: Wed Mar 12 02:02:47 2014 +0000
Bug 10942: (follow-up) create a /etc/koha/koha-common.conf
This patch creates a new master configuration file for the
koha-common package, and moves the AUTOMATIC_TRANSLATIONS_UPDATE
variable rather than leaving in in /etc/default/koha, which is meant
to be used for init script settings.
The configuration format is simple - a shell script that
sets variables and which can sourced by another script or
trivially parsed.
To test:
- Apply the patch series for bug 10942 and build a package.
- Install the package.
- Verify that a new config file, /etc/koha/koha-common.conf.
- Follow the rest of the test plan for the main page (e.g.,
set AUTOMATIC_TRANSLATIONS_UPDATE and force a package upgrade).
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Robin Sheat <robin at catalyst.net.nz>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 33cc81bbc37046d9a38ff3d4b64f546e5e8f77b8
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Tue Sep 24 14:45:07 2013 -0300
Bug 10942: Provide a way for package upgrades to update template translations
This patch adds a new config variable AUTOMATIC_TRANSLATIONS_UPDATE at
/etc/default/koha-common that is used to control whether the upgrade
process should trigger a
$ koha-translate --update <lang_code>
command for each installed template translation language.
To test:
- Have a koha-common setup with some languages installed
(e.g. koha-translate --install es-ES)
- Apply the patch and build a package for it.
- Install it.
- A new AUTOMATIC_TRANSLATIONS_UPDATE config variable should be in place
at /etc/default/koha-common
- Set AUTOMATIC_TRANSLATIONS_UPDATE to 'yes'
- Re-install the package to trigger the post-install script
- Verify that translations get updated.
Edit: added a warning message for the case AUTOMATIC_TRANSLATIONS_UPDATE=no
and there are translations installed (so they need to get updated).
Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Works as advertised, default behaviour doesn't change.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Robin Sheat <robin at catalyst.net.nz>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
-----------------------------------------------------------------------
Summary of changes:
debian/koha-common.config | 20 +++++++++++-
debian/koha-common.default | 2 ++
debian/koha-common.postinst | 64 +++++++++++++++++++++++++++++++++++++
debian/koha-common.templates | 7 ++++
debian/templates/koha-common.conf | 17 ++++++++++
5 files changed, 109 insertions(+), 1 deletion(-)
create mode 100644 debian/templates/koha-common.conf
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list