[koha-commits] main Koha release repository branch master updated. v3.14.00-952-g8f287ee

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  8f287eebc5a3a3afca5443e8d9f677c293c1ee52 (commit)
       via  9d94396f7596fe30a5cd84ee7ddc7e8ae3af59d2 (commit)
      from  7e8f5f52c05bd425b4251f01f0253303eec6ca96 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 8f287eebc5a3a3afca5443e8d9f677c293c1ee52
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Mon Apr 28 21:32:45 2014 +0000

    Bug 12100: (follow-up) fix regression
    
    This patch fixes a regression on bug 5603 introduced by
    the previous patch by ensuring that if no preferred transports are
    active for a given message, GetMessagingPreferences()
    won't try to populate the transports hash with an undef hash
    key.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 9d94396f7596fe30a5cd84ee7ddc7e8ae3af59d2
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Thu Apr 17 13:30:44 2014 +0200

    Bug 12100: ensure that messaging preferences displays saved Days in Advance
    
    If you have enhanced messaging preference, the Days in Advance combo
    value (in Patron Messaging Preferences) is saved in the database but
    not retrieved when you have not enabled the Email checkbox (or checkbox
    for any other transport) next to it.
    
    This patch does the following:
    [1] It replaces a JOIN by a LEFT JOIN that is the actual reason of the
        problem described.
    [2] Removes a FIXME by saving a hardcoded 30 into a constant.
    [3] Fixes a typo in the neighborhood.
    [4] Removes a superfluous comma in the map statement.
    [5] Simplifies code for the selected field of the days combo. It should
        just be a boolean. The text selected="selected" is in the template.
    
    Test plan:
    [1] Enable enhanced messaging preferences.
    [2] Fill in Days in advance for Advance notice but uncheck Email.
    [3] Save the preferences.
    [4] The member home screen does not display the number of days (until you
        decide to apply this patch :)
    
    Followed test plan. Works as expected.
    Signed-off-by: Marc Veron <veron at veron.ch>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Form/MessagingPreferences.pm |   10 ++++++----
 C4/Members/Messaging.pm         |    3 ++-
 2 files changed, 8 insertions(+), 5 deletions(-)


hooks/post-receive
-- 
main Koha release repository