[koha-commits] main Koha release repository branch 3.14.x updated. v3.14.09-1-g183aa49

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.14.x has been updated
       via  183aa49e6b646407f3ebb594de738ca34197b4fa (commit)
      from  7682e4203c0b9cdf106d071243aadffdd186f60e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 183aa49e6b646407f3ebb594de738ca34197b4fa
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Fri Apr 11 10:54:57 2014 +0200

    Bug 12071: improve generation of Z39.50 search links
    
    This patch fixes two problems with the generation of
    links to execute a Z39.50 search from the staff client
    catalog and cataloguing search results page.
    
    First, if using URI::Escape 3.30 or earlier, performing a simple search
    with a double quote (e.g., "histoire algerie"), the Javascript is broken
    in results page because of :
    
    function GetZ3950Terms(){
      var strQuery="&frameworkcode=";
      strQuery += "&" + "title" + "=" + ""histoire%20algerie"";
    
    Second, the encoding of non-ASCII characters in the search
    term was broken.
    
    This patch moves URI escaping from Perl to template with uri TT filter.
    
    Test plan :
    - To reproduce the issue with double quotes, the server
      must be running URI::Escape 3.30 or earlier; the current
      version of URI::Escape properly escapes double quote.
    - In staff interface, perform a search with double quotes
      that will return no result, ie "aaa xxx"
    => Without patch, javascript is broken
    => With patch, javascript is not broken
    - Click on Z3950 button on results page
    => Without patch, the Title input is empty
    => With patch, the Title input contains the search terms
    
    Additional test:
    Do a search with something like äöü and then click Z3950
    button on results page.
    Without patch, encoding is broken in Z3950 form
    With patch, encoding is correct.
    
    Signed-off-by: Marc Véron <veron at veron.ch>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Fixed a few tabs. Passes tests and QA script.
    I can't reproduce the Javascript problem, but I can reproduce
    the Z39.50 encoding problem and can detect no regression.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 064d5478d31b05442e19b7d57f0af94d3422731e)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Search.pm                                                   |    8 ++++----
 koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc       |    2 +-
 koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt   |    2 +-
 .../intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt      |    2 +-
 4 files changed, 7 insertions(+), 7 deletions(-)


hooks/post-receive
-- 
main Koha release repository