[koha-commits] main Koha release repository branch master updated. v3.16.00-359-gfad7daf

Wed Aug 6 00:57:04 CEST 2014

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  fad7daf10261d59e5e40ea84d4caaae9bd87d4e0 (commit)
       via  129cedf943c09d084ad6e09e8de60a87962094e6 (commit)
       via  dda53be4900b9b5b6171af3d865306e71415ee06 (commit)
       via  7a5eac3a51b3dc5b344c91a729b282a191bf2c8e (commit)
       via  d3ece3601504e51878b00e49f9911e80b5337ac3 (commit)
       via  6e13e16db34e61d90d358b05af6f5d9d2751f70f (commit)
      from  4e278782f156a9d7452e6e9ddcefee9542b964fc (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit fad7daf10261d59e5e40ea84d4caaae9bd87d4e0
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Tue Jul 29 08:57:54 2014 +0200

    Bug 11331 - CSV export for viewlog.pl is missing newlines - followup

    Perl formatting and cleaning.
    Also corrects the HTML of results table in viewlog.tt.

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 129cedf943c09d084ad6e09e8de60a87962094e6
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Fri Jul 25 17:01:42 2014 +0200

    Bug 11331 - CSV export for viewlog.pl is missing newlines

    When you try to export the result of tools/viewlog.pl in csv, file
    cannot be correctly loaded :
      - newline is missing after each record,
      - strings should be enclosed in ""
      - columns are not the same as for screen output

    This patch corrects this by using like other export Text::CSV.
    Adds a header line made with the keys of first data. For that, all data
    values are initialiszed with empty string.

    Test plan :
    - Use a database with some logs, see sysprefs
      /cgi-bin/koha/admin/preferences.pl?tab=logs
    - Go to export page /cgi-bin/koha/tools/viewlog.pl
    - Select a module
    - Click on "To a file" and choose a file name
    - Click on "Submit"
    - Open file
       => Without this patch : newline is missing, multi-lines cells are not
          enclosed in "", there are no column headings
       => Without this patch : each line is a data line, complexe cells are
          enclosed in "", there are column headings
    - Test the export of all modules to see that all headings are necessary
    - Check the output to screen in the browser

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    The CSV export is significantly improved. I question the usefulness of
    including biblioitemnumber in the output. A better inclusion would be
    itemnumber.

    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

    While this feature is still not perfect, this is a big improvement.
    Passes tests and QA script, restores basic functionality.

    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit dda53be4900b9b5b6171af3d865306e71415ee06
Author: Brian Norris <briann at catalyst.net.nz>
Date:   Fri Jul 25 14:55:04 2014 +1200

    Bug 12660:Correct mispelling of accomodate in comments

    View the file in your git checkout to see the misspelling of accomodate
    do the patch
    view the files again to see the correct spelling accommodate

    Patch behaves as expected.
    Signed-off-by: Marc Véron <veron at veron.ch>

    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Fixes typos to correct spelling.

    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 7a5eac3a51b3dc5b344c91a729b282a191bf2c8e
Author: Fridolyn SOMERS <fridolyn.somers at biblibre.com>
Date:   Fri Jul 26 17:02:01 2013 +0200

    Bug 10648 - In records merge greatest field can not be added

    When merging 2 records (/cgi-bin/koha/cataloguing/merge.pl), the destination record is build using the fields and subfields checked in source records.
    When a field is checked, the javascript code searches in destination record a field with a greater tag number to insert new field before.
    When the new field tag number is greater than all existing field tag numbers, the field is not added.

    This patch corrects this by adding at end if no greater field tag number exists. Also adds a sort of fields by tag number because all mergo code is based on this.

    Test plan :
    - Add to a framework a repeatable field with the greater non existing tag number. For example 998.
    - Edit 2 records with this framework and add them a value in this tag.
    - Put those records is a list
    - Go to this list and check the two records
    - Click on "Merge selected"
    - Click on next
    - Go to second source record
    - Click on the greatest tag number. for example 998.
    => The field is added at the end of destination record

    Signed-off-by: Nick Clemens <nick at quecheelibrary.org>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    Works as described, no regressions.

commit d3ece3601504e51878b00e49f9911e80b5337ac3
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Wed Jul 16 15:32:08 2014 -0400

    Bug 4013 [Revised] road type missing on search results

    On the patron search results page there are several patron fields which
    do not show: street number, road type, and state. This patch adds them.

    To test, go to Patrons -> Search patrons and perform a search. In the
    table of patron search results each patron record should display the
    correct information including street number, road type, and state.

    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Works as described, passes tests and QA script.

    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    Works as described.

commit 6e13e16db34e61d90d358b05af6f5d9d2751f70f
Author: David Cook <dcook at prosentient.com.au>
Date:   Fri Aug 1 16:42:34 2014 +1000

    Bug 12690 - opacuserjs gets loaded twice in self checkout

    This patch removes a second instance of "opacuserjs" in the opac
    self-checkout.

    _TEST PLAN_

    1) Enable OPAC Self-checkout in the system preferences
    2) Type the following code into your "opacuserjs" system preference:

    alert("This is a test");

    2) Visit /cgi-bin/koha/sco/sco-main.pl
    3) Note that you get a pop-up saying "This is a test" twice.

    4) Apply the patch

    5) Refresh /cgi-bin/koha/sco/sco-main.pl
    6) Note that you now only get a pop-up saying "This is a test" once.

    Followed test plan, patch behaves as expected.
    Signed-off-by: Marc Véron <veron at veron.ch>

    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    opac-bottom.inc already adds opacuserjs, so the additional line
    in this template can be removed.
    Works as described, no problems found.

    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Log.pm                                          |    1 -
 C4/Utils/DataTables/Members.pm                     |    7 +-
 koha-tmpl/intranet-tmpl/prog/en/js/merge-record.js |   16 +-
 .../en/modules/members/tables/members_results.tt   |    3 +-
 .../prog/en/modules/tools/batchMod-del.tt          |    2 +-
 .../prog/en/modules/tools/batchMod-edit.tt         |    2 +-
 .../intranet-tmpl/prog/en/modules/tools/viewlog.tt |   21 +-
 .../opac-tmpl/bootstrap/en/modules/sco/sco-main.tt |    1 -
 tools/viewlog.pl                                   |  230 +++++++++++---------
 9 files changed, 158 insertions(+), 125 deletions(-)

hooks/post-receive
-- 
main Koha release repository