[koha-commits] main Koha release repository branch 3.14.x updated. v3.14.09-36-ga7b28d1

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.14.x has been updated
       via  a7b28d19a71f16ebad3805139e7f82f268d77c5c (commit)
      from  2b58ea23227bd0539942cdffa4f51b5f86cddf50 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a7b28d19a71f16ebad3805139e7f82f268d77c5c
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Fri Apr 11 18:49:07 2014 +0000

    Bug 12076: better detect an untranslatable template construct
    
    Per bug 6458, template constructs of the form
    
    <li [% IF (foo) %]selected="selected"[% END %]...
    
    are forbidden as they can cause problems with translated templates.
    However, the tt_valid.t test currently doesn't catch the variation
    where '-' is used to suppress extra whitespace:
    
    <li [%- IF (foo) -%]selected="selected"[%- END -%]...
    
    This patch corrects the issue.
    
    To test:
    
    [1] Temporarily add the following line to a template file:
    
    <li [%- IF a -%]a="a"[%- END -%] />
    
    [2] Run prove -v xt/tt_valid.t.  Note that no error is reported.
    [3] Apply the patch, and rerun the tt_valid.t test.  This time,
        an error should be reported.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    
    Works well, detects the forbidden pattern
    No koha-qa errors.
    
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Works as described, passes all tests and QA script.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 9a7eedce78af128772a36b5a16416fdad1a16fcc)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-----------------------------------------------------------------------

Summary of changes:
 xt/tt_valid.t |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


hooks/post-receive
-- 
main Koha release repository