[koha-commits] main Koha release repository branch 3.14.x updated. v3.14.09-45-gb2651d7

Git repo owner gitmaster at git.koha-community.org
Wed Aug 6 10:49:36 CEST 2014


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.14.x has been updated
       via  b2651d7b5394f36a27f4301a5d0a4978473e487f (commit)
       via  6bf8a6c62eb1ecdb9624f468e793239d2362ebb5 (commit)
       via  be59e84075767f51f856949380081059a6aee364 (commit)
       via  178c50bb802928e71869d076a9d16a012377144a (commit)
      from  269eb184e97652c48f8c04bdf512aaef421da5b8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit b2651d7b5394f36a27f4301a5d0a4978473e487f
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Tue Apr 15 15:16:42 2014 +0000

    Bug 11797: (follow-up) fix MARC21 branch of bug more idiomatically
    
    This patch puts the MARC21 variant of the bugfix in alignment
    with the UNIMARC variant, removing the use of unnecessary
    temporary variables.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit cc7a99ba7f23c7f77bb28c23613fbd9b4ab61cd5)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 6bf8a6c62eb1ecdb9624f468e793239d2362ebb5
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Tue Apr 15 11:08:54 2014 +0200

    Bug 11797: fix odd number of elements in hash (UNIMARC)
    
    I got the same warning for my UNIMARC DB.
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit fa989631f6b6f2d4a6dc86e8b9535bd9ce786c1e)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit be59e84075767f51f856949380081059a6aee364
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Thu Mar 6 01:29:39 2014 -0500

    Bug 11797: fix odd number of elements in hash warning (MARC21)
    
    This was discovered when someone triggered an authority search
    on an authority record that was missing what is assumed the
    default subfield for a given field.
    
    It, however, also can be triggered in an OPAC authority search
    by looking at the record that lacks the default subfield for a
    given field.
    
    TEST PLAN
    ---------
    1) Create an authority record with 180$x and NOT 180$v.
       See C4::AuthoritiesMarc::BuildSummary in the 1.. foreach loop
       for known tags and default values. The default subfields are
       the first letter of the $subfields_to_report string.
    2) Trigger the bug:
       Method 1: /cgi-bin/koha/opac-authoritiesdetail.pl?authid=#
                 Where # is the authority id of your tweaked record.
                 The error occurs in Normal view.
       Method 2: Home -> Cataloging -> + New record
                      -> Click the 'Tag Editor' on 100$a
                      Editing of $a to $b and back may be required.
    3) Notice there is an error log entry.
    4) Apply the patch
    5) Attempt to trigger the bug again
    6) That specific error log entry is not generated.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Could generate the warning with a missing 151$a with both methods.
    No warning anymore after applying this patch.
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 129bc3281180d892659d3ad1ef253fbc7ec6f316)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 178c50bb802928e71869d076a9d16a012377144a
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Tue Apr 15 15:38:49 2014 +0000

    Bug 11797: add regression test
    
    This patch adds unit tests for C4::AuthoritiesMarc::BuildSummary
    for both UNIMARC and MARC21 and a regression test for the "Odd
    number of elements in anonymous hash" warning.
    
    To test:
    
    [1] Run prove -v t/db_dependent/AuthoritiesMarc.t.  It should
        report one failure.
    [2] Apply the main patch.
    [3] Run t/db_dependent/AuthoritiesMarc.t again; it should pass.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit f2b655dfabc4a4464099e7d9bc219b6714ef7de1)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/AuthoritiesMarc.pm            |   12 ++---
 t/db_dependent/AuthoritiesMarc.t |   95 +++++++++++++++++++++++++++++++++++++-
 2 files changed, 100 insertions(+), 7 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list