[koha-commits] main Koha release repository branch 3.14.x updated. v3.14.09-82-g942271c
Git repo owner
gitmaster at git.koha-community.org
Thu Aug 7 09:19:10 CEST 2014
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 3.14.x has been updated
via 942271cd9ca306ff7b25c75eea9f815b079a0947 (commit)
from 6a8ee565480d1dbb3a50675e022ee24bc0eda9b9 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 942271cd9ca306ff7b25c75eea9f815b079a0947
Author: Galen Charlton <gmc at esilibrary.com>
Date: Mon Dec 30 16:05:51 2013 +0000
Bug 7002: fix some invalid superlibrarian permission checks
This patch fixes a problem where if a staff user has superlibrarian
permissions, but also has module-specific permissions, they are
prevent from editing item records that they should be allowed to.
To test:
[1] Turn on IndependentBranches.
[2] Register a superlibrarian staff user at branch A.
[3] Give that new account at least one other module-level
permission. This cannot be done through the user interface,
however, but can be done via SQL:
UPDATE borrowers SET flags = 3 WHERE userid = 'XXX';
[4] Log in as that new superlibrarian.
[5] Bring up the item details (catalogue/moredetail.pl) page for
an item at branch B. Note that there is no 'Edit Item' link.
[6] Similarly, try editing that item (cataloging/additem.pl). Note
that the edit form forbids you from touching the item.
[7] Finally, try editing that item using the Tools | Batch item
modification utility. Note that it doesn't allow you to do so.
[8] Apply the patch.
[9] Repeat steps 5 through 7. This time, the item actions should
be allowed.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Works as described, passes QA script and test suite.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
(cherry picked from commit bb750253644e0ba6ea04e36c80088626e8163bf2)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
-----------------------------------------------------------------------
Summary of changes:
catalogue/moredetail.pl | 2 +-
cataloguing/additem.pl | 2 +-
tools/batchMod.pl | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list