[koha-commits] main Koha release repository branch 3.14.x updated. v3.14.09-87-g39498e7

Git repo owner gitmaster at git.koha-community.org
Thu Aug 7 09:49:50 CEST 2014


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.14.x has been updated
       via  39498e72f5b72d0ebe4df9b5a803a0432e65df7d (commit)
       via  59826b04cb983eca630eb0665be58dfd7d6fa622 (commit)
      from  a7d46e6ac9d0c1234c049dde9af8c73de58f2aba (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 39498e72f5b72d0ebe4df9b5a803a0432e65df7d
Author: Frédéric Demians <f.demians at tamil.fr>
Date:   Tue Apr 8 17:26:18 2014 +0200

    Bug 12048: restore ability of superlibrarian to see other libraries' subscriptions
    
    This patch fixes a regression in master and 3.14. When a user has
    superlibrian permissions, a search on serials subscriptions should
    display other libraries' subscriptions even when IndependentBranches
    syspref is enabled.
    
    To reproduce/test the bug/patch:
    
    1. Enable IndependentBranches (i.e. 'Prevent' staff...)
    2. Login as a user not having superlibrarian permission
    3. Search for a serial subscription on:
       /cgi-bin/koha/serials/serials-search.pl
    4. Search a title which has at least 2 subscriptions: one in the user
       branch, and one in another branch
    5. On the result page, just 1 subscription is displayed: the one
       attached to the userbranch
       => this is normal
    6. Login as a user having superlibrarian permission
    7. Repeat step 3-5.
    8. You get the same result as 5. You should have seen all subscriptions.
       That's what you get after applying this patch.
    
    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    
    NOTE: I tested a variation. My superlibrarian was a branch that
          was not the same as the non-superlibrarian. The serial was
          the same branch as the non-superlibrarian. Without the
          patch, the superlibrarian saw nothing, with the patch it
          saw the serial as expected.
          Also, remember the superserials permission can affect the
          results. I successfully changed the branch of the
          subscription, and then it ceased to show up with
          superserials not granted to the non-superlibrarian.
          I corrected the system preference name in the text here.
    
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Superlibrarian permission now allows to see all subscriptions
    independent from the branch.
    Passes all tests and QA script.
    
    But the superserials permission appears broken to me before
    and after this patch. If I have superserials - the search
    doesn't show all subscriptions. If I don't have superserials
    I can still edit any subscription accessing the subscription
    detail page through the serial collection page or accessing
    the detail page directly by manipulating the URL.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 214d6b8d13c553027c868a00a2dd6b313f56608b)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 59826b04cb983eca630eb0665be58dfd7d6fa622
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Fri Apr 18 19:56:51 2014 +0000

    Bug 12048: add regression test
    
    This patch adds a regression test for verifying that superlibrarians
    can see all subscription when IndependentBranches is on.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 9af0aa288c23a6722333adebba7b8b3e12ed78e2)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Serials.pm               |    2 +-
 t/db_dependent/Bookseller.t |   50 +++++++++++++++++++++++++++++++++++++++----
 2 files changed, 47 insertions(+), 5 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list