[koha-commits] main Koha release repository branch 3.14.x updated. v3.14.09-93-g20c1fac
Git repo owner
gitmaster at git.koha-community.org
Thu Aug 7 09:59:30 CEST 2014
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 3.14.x has been updated
via 20c1fac16bdc51e9653ad9a79d7bcdddcbc0fd60 (commit)
via 15716da33e995a176822d9d218a599a544644af1 (commit)
via 9de01117b268b8ba878cf5e50aaabfecb8bed6fe (commit)
via 38189555a346751287315453bce46880d13c701e (commit)
from dc3bb08992e47800dfb887d72b54c2677d7ab198 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 20c1fac16bdc51e9653ad9a79d7bcdddcbc0fd60
Author: Galen Charlton <gmc at esilibrary.com>
Date: Fri Apr 18 20:47:48 2014 +0000
Bug 12098: (follow-up) put can_show_subscription() into use
This patch puts C4::Serials::can_show_subscription() into use.
Note that there is user-visible change: if a subscription has a
blank library, all users with serials permissions will be able
to view and/or edit it. It remains to be determined whether
we *want* such subscriptions to exist, or if they should only
be tied to specific libraries.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
(cherry picked from commit dc6d8a2199f79e36839a2769994883e04b61cb67)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 15716da33e995a176822d9d218a599a544644af1
Author: Galen Charlton <gmc at esilibrary.com>
Date: Fri Apr 18 20:17:27 2014 +0000
Bug 12098: (follow-up) deal with FIXMEs in t/db_dependent/Serials_2.t
This patch nails down the number of tests to be run.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
(cherry picked from commit be3ce1e7a2477b02d4c071543405898c21380926)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 9de01117b268b8ba878cf5e50aaabfecb8bed6fe
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Wed Apr 16 16:58:36 2014 +0200
Bug 12098: Refactor can_*_subscription in C4::Serials
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Tested on top of patches for 12048 and 12080.
Subscription search
- superlibrarian, IndyBranches on/off - always sees all subscriptions
- superserials, IndyBranches on/off - always sees all subscriptions
- no superserials, IndyBranches on - only sees own subscriptions
Note: Subscriptions without branches will only show, when all subscriptions
are visible. In a future enh it might be good to enforce setting a
branch, when IndyBranches is used.
- no superserials, IndyBranches off - always sees all subscriptions
Subscription editing
- superlibrarian, IndyBranches on/off - can edit all subscriptions
- superserials, IndyBranches on/off - can edit all subscriptions
- no superserials, IndyBranches on - can only edit own subscriptons and
subscriptions without branch
NOTE: it would make sense to also allow Edit > Edit as new (duplicate)
here, so one can copy the subscription from another branch to modify
it for the own branch.
Passes tests in t, xt and QA script, also newly provided unit tests.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
(cherry picked from commit 4d78b9588a9f5fc68142b9d1556686072e7b5dba)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 38189555a346751287315453bce46880d13c701e
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Wed Apr 16 16:50:23 2014 +0200
Bug 12098: Fix C4::Serials::can_edit_subscription
This patch fixes a problem whereby staff users could
edit subscriptions they are not permitted to by going directly
to the subscription details page.
It also adds some unit tests for the can_edit_subscription routine
and add a new can_show_subscription routines.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Notes on second patch.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
(cherry picked from commit 4f7803e469a41cafb993c6d41e6481499e6cca93)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Serials.pm | 71 +++++++++-----
t/db_dependent/Serials_2.t | 219 +++++++++++++++++++++++++++++++++++++++-----
2 files changed, 242 insertions(+), 48 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list