[koha-commits] main Koha release repository branch master updated. v3.16.00-386-g80a1225
Git repo owner
gitmaster at git.koha-community.org
Mon Aug 11 14:38:02 CEST 2014
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 80a1225bb732fb957af483cfa64face8631165bf (commit)
via ad0d975eda9408fbb4342fb0753f4dd40d9c63f0 (commit)
from be7009fdb777fc7e3cc9f3fe598f938185743c12 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 80a1225bb732fb957af483cfa64face8631165bf
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Fri Aug 8 12:01:36 2014 -0300
Bug 12738: C4::Context should set 'keyword' as the default search class
On a Perl 5.18 environment (e.g. Ubuntu 14.04 LTS):
To reproduce:
- Have UseQueryParser == "Don't try"
- Perform a search typing just a word that would have many matches on your Zebra db.
- Take note of the search results count.
- Make sure you have the queryparser.yaml file in your config dir.
- Set UseQueryParser == "Try"
- Perform the same search a couple of times
=> FAIL: Notice that the search results count differs from one run to the other.
- Run the regression tests
$ prove -v t/db_dependent/QueryParser.t
=> FAIL: tests fail
To test:
- Apply the patch
- Run tests
$ prove -v t/db_dependent/QueryParser.t
=> SUCCESS: tests pass
- Repeat the steps 'To reproduce'
=> SUCCESS: Search results count is deterministic :-D
- Sign off :-D
Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Now search with QueryParser always returns the correct number of
results on a system with the newer Perl version.
Passes all tests and QA script.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit ad0d975eda9408fbb4342fb0753f4dd40d9c63f0
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Fri Aug 8 11:59:43 2014 -0300
Bug 12738: (regression tests) C4::Context should set keyword search as default for QueryParser
This patch introduces tests for the QueryParser PQF driver usage in Koha. Specifically its
initialization on C4::Context, and initial setup.
It also introduces a .pl script that is used to load C4::Context with different hash randomization
seeds on purpose, to verify the initialization result is deterministic and consistent between
runs.
To test:
$ prove -v t/db_dependent/QueryParser.t
It should fail because different default_search_class is set on each run, and it is not often the
one we expect.
Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Context.pm | 2 +
t/db_dependent/QueryParser.t | 70 ++++++++++++++++++++
.../db_dependent/default_search_class.pl | 27 +++++---
3 files changed, 88 insertions(+), 11 deletions(-)
create mode 100644 t/db_dependent/QueryParser.t
copy Koha/SearchEngine/Zebra/QueryBuilder.pm => t/db_dependent/default_search_class.pl (63%)
mode change 100644 => 100755
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list