[koha-commits] main Koha release repository branch master updated. v3.16.00-392-g54e7212

Mon Aug 11 16:20:03 CEST 2014

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  54e7212edd3018772c0d09261613fbb9bfb184d1 (commit)
       via  efee30f394bd89632e262d6605d4623a8ee2d9f9 (commit)
       via  f95cd090b63e3491db8618efcc5faa3859fca322 (commit)
       via  6768c2874bcb11fc8cf7e155e7686ea7eaa8858d (commit)
       via  449b365a4822141920706d61a5ca466a86e6a6fa (commit)
      from  27eccf412217c18f282ae9e97e94885209a9ba69 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 54e7212edd3018772c0d09261613fbb9bfb184d1
Author: Jacek Ablewicz <abl at biblos.pk.edu.pl>
Date:   Thu Aug 7 10:29:37 2014 +0200

    Bug 12727 - Patron category filter in batch patron deletion tool is broken

    After commit 6973e3b7d50777a147a29f2f3d213a6175c9eb74, patron category
    filter in batch patron deletion tool (tools/cleanborrowers.pl) doesn't
    work properly any longer. It's still possible to choose a patron
    category as selection criterion, but this criterion is being
    efectivelly ignored on futhers steps.

    As a result, all patrons (with no check-outs and no outstanding
    account balance) may get mistakenly deleted when using this tool,
    despite their respective categories.

    To test:

    1/ apply patch
    2/ follow the test plan[s] for Bug 11975

    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Works as described, no problems found.

    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit efee30f394bd89632e262d6605d4623a8ee2d9f9
Author: Yohann Dufour <dufour.yohann at gmail.com>
Date:   Fri Aug 8 15:50:12 2014 +0200

    Bug 12623: SQLHelper replacement - Borrower::Modifications

    With this patch, the subroutines AddModification and ApproveModifications uses DBIx::Class instead of C4::SQLHelper.
    Moreover, the tests has been wrapped in a transaction.

    Test plan:
    1) Apply the patch

    2) Execute the unit tests by launching :
    prove t/db_dependent/Koha_borrower_modifications.t

    3) The result has to be a success without error or warning :
    t/db_dependent/Koha_borrower_modifications.t .. ok
    All tests successful.
    Files=1, Tests=14,  2 wallclock secs ( 0.03 usr  0.01 sys +  1.60 cusr  0.08 csys =  1.72 CPU)
    Result: PASS

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit f95cd090b63e3491db8618efcc5faa3859fca322
Author: Marc Véron <veron at veron.ch>
Date:   Mon Jul 21 11:03:12 2014 +0200

    Bug 12700 - Capitalization: "Close Help Window" in context help

    To test:
    - Open help in any page of staff client
    - In help popup window, see wrong capitalization in button 'Close Help Window'
    - Close the popup window
    - Apply patch
    - Check again: Button now reads "Close help window'

    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Work as described, no koha-qa errors

    Signed-off-by: Nick Clemens <nick at quecheelibrary.org>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 6768c2874bcb11fc8cf7e155e7686ea7eaa8858d
Author: David Cook <dcook at prosentient.com.au>
Date:   Tue Jul 22 09:26:03 2014 +1000

    Bug 10542: QueryParser + OpacSuppression doesn't allow search in 'all libraries'

    Since we're using the $query_type variable to detect if this pre-built
    query is PQF, we need to use PQF syntax (rather than QueryParser
    syntax) when adding to the query. I've made a lot of notes of somewhat
    incoherent notes on Bugzilla talking about PQF, CCL, and QP syntaxes,
    but I'm hoping to refine these notes on a wiki page for future
    reference.

    _TEST PLAN_

    1) Set 'Suppress in Opac' (ie 942$n) to 1 for one record
    2) Re-index Zebra
    3) Set 'OpacSuppression' to 'Hide'
    4) Set 'UseQueryParser' to 'Do not try'
    5) In the staff client, do a search that will return that suppressed
    record as well as a few records that are NOT suppressed
    6) Note that you can return that suppressed record in the staff client
    7) Do the same search in the OPAC
    8) Note that the suppressed record doesn't appear
    9) Set 'UseQueryParser' to 'Try' && re-run the OPAC search
    10) Note that no results appear (the logs will probably mention a
    ZOOM error)

    11) Apply patch

    12) Re-run the OPAC search
    13) Note that the suppressed record doesn't appear, and that the
    not suppressed records are showing (it's important that you are
    getting some results...as ZOOM errors are silent in the UI).
    14) Set 'UseQueryParser' to 'Do not try'
    15) Re-run the search
    16) Note that the suppressed record doesn't appear, and that the
    not suppressed records are showing

    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

    Work as described following test plan.
    No koha-qa errors.

    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Works as described - hidden records are hidden.
    Passes tests and QA script.

    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 449b365a4822141920706d61a5ca466a86e6a6fa
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Wed Mar 12 17:43:20 2014 +0000

    Bug 10542: Fix QueryParser with OpacSupression

    OpacSupressions manipulates the query string after the buildQuery
    call and so breaks with queryParser enabled.  This patch adds
    checks for queryParser and manipulates the query before passing it
    to buildQuery if it is enabled, but leaves the post buildQuery
    manipultation when queryParser is disabled

    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Adding a sing after test

    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/Borrower/Modifications.pm                     |   55 +++++++-------------
 .../intranet-tmpl/prog/en/includes/help-bottom.inc |    2 +-
 opac/opac-search.pl                                |   13 ++++-
 t/db_dependent/Koha_borrower_modifications.t       |   18 ++++---
 tools/cleanborrowers.pl                            |    2 +-
 5 files changed, 43 insertions(+), 47 deletions(-)

hooks/post-receive
-- 
main Koha release repository