[koha-commits] main Koha release repository branch 3.14.x updated. v3.14.09-103-g0ddc2b9

Git repo owner gitmaster at git.koha-community.org
Wed Aug 13 09:45:01 CEST 2014


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.14.x has been updated
       via  0ddc2b90f9068ef8a30efb845dd84b70041cf7e5 (commit)
      from  11a890df5ab01c504d799d813f70cd6c841379b3 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 0ddc2b90f9068ef8a30efb845dd84b70041cf7e5
Author: Fridolyn SOMERS <fridolyn.somers at biblibre.com>
Date:   Fri Nov 15 10:43:21 2013 +0100

    Bug 11254: make reservoir search normalize ISBNs
    
    When importing records, the ISBN is normalized and stored
    into database (see C4::ImportBatch::_add_biblio_fields).  But when
    searching with ISBN into reservoir, it is not normalized
    (see C4::Breeding::BreedingSearch).  So search does not match.
    
    This patch adds the normalisation to reservoir search.  Also, it
    replaces call private method _isbn_cleanup by GetNormalizedISBN,
    the correct public method.  Also allows the reservoir search
    on ISBN with hyphens.
    
    This is intended to fix only reservoir searches.
    
    Revised Test plan
    -----------------
     1) Back up DB
     2) Save copy of attached example somewhere findable
     2) Home -> Tools -> Stage MARC records for import
     3) Click Browse and select the example MARC file
     4) Click Upload file
     5) Tweak as desired then click Stage for import
     6) Click Manage staged records
     7) Click Import this batch into the catalog
     8) Home -> Cataloging
     9) In the Cataloging search text box type 978-0-691-14289-0 and
         click Submit
        -- ISBN13 with hypens not found in reservoir
    10) In the Cataloging search text box type 9780691142890 and
         click Submit
        -- ISBN13 without hypens not found in reservoir
    11) In the Cataloging search text box type 0-691-14289-0 and
         click Submit
        -- ISBN10 with hypens not found in reservoir
    12) In the Cataloging search text box type 0691142890 and
         click Submit
        -- ISBN10 without hypens found in reservoir
    13) Apply patch
    14) Repeat steps 9-12, this time it is always found! :)
    
    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit cac06afeb1f03200cfc7ab48162c184be8d1526b)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Breeding.pm          |    5 ++++-
 C4/ImportBatch.pm       |    2 +-
 cataloguing/addbooks.pl |    4 +++-
 3 files changed, 8 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list