[koha-commits] main Koha release repository branch master updated. v3.16.00-398-gde7dd39
Git repo owner
gitmaster at git.koha-community.org
Wed Aug 13 15:28:01 CEST 2014
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via de7dd395838ebe1ac944540cbd74fb409003d70b (commit)
via 5b72546ffbb564bece5097e40ce44a91c7b944f8 (commit)
via 1b25d910ae7e59428876b18394e7d549c25006a3 (commit)
from 9561bab783b83e317b2eb0a646e87ee6ca535ed1 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit de7dd395838ebe1ac944540cbd74fb409003d70b
Author: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Date: Fri Jul 18 22:51:22 2014 -0300
Bug 766: Remove CGI::scrollinglist from marctagstructure.pl
This patch removes the only instance in this file.
Don't know if the feature is of some utility, seems
that does not work (no use of auth values as indicators
on MARC editor)
To test:
1. Apply the patch
2. Go to Administration > MARC frameworks
3. Clic on MARC structure of any fw
4. Clic Edit on any tag
5. On tag editor check the pulldown 'Authorised value', that was replaced
6. Check for regressions: select a value, save, verify the value, change
again, etc.
Note: removed a SELECT, using now C4::Koha::GetAuthorisedValueCategories
Do not we need an AuthorisedValues.pm? (on C4 or Koha)
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Works as described, passes tests and QA script.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 5b72546ffbb564bece5097e40ce44a91c7b944f8
Author: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Date: Sat Jul 19 00:22:12 2014 -0300
Bug 766: Remove CGI::scrollinglist from authorised_values.pl
This patch removes the only instance in this file.
Also fixes array sorting, removes some tabs, removes
an unneeded $dbh handler (there is a global one).
Makes use of C4::Koha::GetAuthorisedValueCategories.
To test:
1. Apply the patch
2. Go to Administration > Authorised values
3. Replaced pulldown next to 'Show category' must
show all (present & system) categories correctly ordered.
4. Select some and check for regressions, e.g. CCODE, Bsort2, YES_NO
no changes must be observed
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Works as described, no problems found.
Passes tests and QA script.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 1b25d910ae7e59428876b18394e7d549c25006a3
Author: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Date: Mon Jul 14 21:10:57 2014 -0300
Bug 766: Remove CGI::scrolling_list from aqplan.pl
This patch removes 3 occurences on aqplan.pl
To test:
1. You need a budget and a fund
2. Apply the patch
3. Go to Aquisitions, click on your fund
4. Select one of the options on pulldown Planning
e.g. "Plan by months"
5. Now to the left there are two boxes, Filter and Export
a) Filter: (1) pulldown below 'Select planning type'
check that works selecting other values and submit
This pulldown showed originally code types,
untranslatable BTW. Added a TT block to allow translation
and shows legends that match Planning pulldown, but not
the order.
b) Export: pulldowns for filetype (2) and delimiter (3)
Those have originally one value each, and for me Export
does not work, before or after patch, but check that
pulldown exist.
Notes:
A) 5.a) I can change de order of main Planning pulldown,
is harcoded. The values for Filter pulldown are sorted on
aqplan.pl. Is one or the other.
If desired, TT block can be moved to includes/budgets-admin-toolbar.inc
(where hardcoded Planning lives)
B) 5.b) Moved 'Export' legend inside it's box, like Filter.
C) Finally: there is something strange, before or after patch.
There is an empty option 'Planning by " if you select planning
using main pulldown, it disappears if you select planning using
Filter (not a mistery, using Planning fills $auth_cats_loop,
using Filter submit button does not)
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Looks like this needs more work, but no regressions found that were
caused by the patch.
Passes tests and QA script.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
-----------------------------------------------------------------------
Summary of changes:
admin/aqplan.pl | 32 ++++-------------
admin/authorised_values.pl | 32 ++++++++---------
admin/marctagstructure.pl | 21 ++++-------
.../intranet-tmpl/prog/en/modules/admin/aqplan.tt | 37 ++++++++++++++++----
.../prog/en/modules/admin/authorised_values.tt | 14 +++++++-
.../prog/en/modules/admin/marctagstructure.tt | 12 ++++++-
6 files changed, 81 insertions(+), 67 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list