[koha-commits] main Koha release repository branch master updated. v3.16.00-416-g78559bb
Git repo owner
gitmaster at git.koha-community.org
Fri Aug 15 19:59:25 CEST 2014
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 78559bb6f585343e842f217235991c08f749c024 (commit)
via 313017f85272631f023a1b900903b81b2e9670c7 (commit)
via 9626daa2207fb0a72e7d779e961ea40c3e4dce27 (commit)
via 5a9786eea86161d20e5bfb2d75a6681f0fbc02f6 (commit)
via 52172938c242bbf5399101442fe13008c21625dd (commit)
via e5dd0e35cab68f296f04b333281869c10de07005 (commit)
via ce1ed2fab4255e9e0cc7785afed27135a16ec04e (commit)
from ba107bb8875d7f9194cdb499d09c9faee81c1e8b (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 78559bb6f585343e842f217235991c08f749c024
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Mon Jul 28 17:36:01 2014 -0400
Bug 12666 - Fix poor HTML from circ/offline.tt
In koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt
- Cleaned up the HTML's missing </div>'s
- Corrected the autobuffer attribute to the newer preload one
- Added into empty title, since it will get replaced
TEST PLAN
---------
1) Run the circ/offline.pl page source through an HTML validator
-- should get a few warnings
2) Apply patch
3) Recheck page source (confirm your page isn't cached!)
-- should be clean
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Improves HTML validity, no regressions found.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 313017f85272631f023a1b900903b81b2e9670c7
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Wed Aug 13 12:54:30 2014 -0400
Bug 12091: HTML from auth_subfields_structure.tt doesn't pass firefox's html validator
This cleans up the HTML in auth_subfields_structure.pl and
auth_subfields_structure.tt by:
- fixing some attributes
- removing some attributes
- and using a handy-dandy validation plug-in that Owen pointed
me at the other day.
TEST PLAN
---------
1) Install HTML Validator Plugin (Html Validator 0.9.5.8 Firefox addon)
2) Log in to staff client
3) Koha administration
4) Authority types (on the right, 5 down from Catalog header)
5) Click 'MARC structure' of any auth type
6) Click 'subfields' (I believe for any Tag >= 010)
7) Click 'Edit subfields'
8) Right click and select 'View Page Source'
-- Lots of HTML validation errors
9) View the 'Authorized value:' and 'Thesaurus:' drop down lists.
-- Patch cleans up code, so lists should remain unchanged
after applying patch
10) Apply the patch
11) Refresh the page (make sure it isn't cached!)
12) Right click and select 'View Page Source'
-- It should be down to 10 errors / 11 warnings.
NOTE: I think this means there is a code problem with
actually editing authorities properly!
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Work as described, much less validation errors, no koha-qa errors
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
CÃleans up code, also removes SQL in favor of using a method.
No regressions found.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 9626daa2207fb0a72e7d779e961ea40c3e4dce27
Author: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Date: Sun Aug 3 16:55:44 2014 -0300
Bug 12707: Remove CGI::scrolling_list from some Reports
This patch removes similar instances on 5 files, same code.
Also removes a commented one, changed in case some plan to
resurrect the code.
This bug depends on Bug 12696.
In all cases but the commented one, what was replaced
is a pulldown with one value, 'CSV'
To test:
1. Apply patch for Bug 12696
2. Apply this patch
Check for the pulldown 'Into an application'
3. Go to Reports > Statistics wizard > Borrowers
4. Go to Reports > Statistics wizard > Circulation
5. Go to Reports > Statistics wizard > Holds
6. Go to Reports > Top lists > Most-circulated items
7. Go to Reports > Inactive > Patrons who haven't checked out
8. There is also a commented code on catalogue_stats, no fuctional
changes.
Followed test plan. Patch behaves as expected.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Works as described, passes tests and QA script.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 5a9786eea86161d20e5bfb2d75a6681f0fbc02f6
Author: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Date: Sun Aug 3 16:08:38 2014 -0300
Bug 12706: Remove CGI::scrolling_list from serial_stats.pl
This patch depends on Bug 12696
Removed one instance in this file.
Pulldown with one value, 'CSV'
To test:
1. Apply the patch for Bug 12696
2. Apply this patch
3. Go to Reports > Statistics wizard > Serial
4. Check 'Into an application' pulldown, with value 'CSV'
5. Search for regressions
Followed test plan. Patch behaves as expected.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes tests and QA script, works as described.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 52172938c242bbf5399101442fe13008c21625dd
Author: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Date: Fri Aug 1 23:23:48 2014 -0300
Bug 12696: Remove CGI::scrolling_list from C4/Reports.pm
This patch removes only instance in this file.
Problem is that there are many template files
involved. Most of them have other instances of
scrolling_lists but is a problem for other bugs,
they will depend on this.
What is replaced is a pulldown for delimiter choices.
In all but one case the code is the same (variable name change),
and I did a little tidy of the TT code
To test:
1. Apply the patch
In all the following cases, check delimiters pulldown (Output box, bottom right)
2. Go to Reports > Statistics wizard > Acquisitions
3. Go to Reports > Statistics wizard > Patrons
4. Go to Reports > Statistics wizard > Catalog
5. Go to Reports > Statistics wizard > Circulation
6. Go to Reports > Statistics wizard > Serials
7. Go to Reports > Statistics wizard > Holds
there is a bug here, pulldown next to this must show 'CSV' option,
but shows nothing. Will be fixed
8. Go to Reports > Other > Average loan time
9. Go to Reports > Top lists > Patron checking out the most
Here there is a 'Delimiter' label before delimiters, only case
10. Go to Reports > Top lists > Most-circulated items
11. Go to Reports > Inactive > Patrons who haven't checked out
There is and inconsistency here, name of option on reports page,
and name on this report, 'Patrons with no checkouts'
Followed test plan. Pulldowns display as expected.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Works as described, passes tests and QA script.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit e5dd0e35cab68f296f04b333281869c10de07005
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Fri Aug 15 12:45:10 2014 -0300
Bug 12745: (QA followup) remove misleading 'No warnings' message
Current code displays "No warnings" even if there are actually warnings
printed.
It is not related to the bug itself, but as it was pointed out by the QAM,
I attach a followup to solve that.
Regards
To+
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
commit ce1ed2fab4255e9e0cc7785afed27135a16ec04e
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Mon Aug 11 12:09:16 2014 -0300
Bug 12745: Add a sanity check for QueryParser configuration on about.pl
Currently there's no way for the user to know he has a bad QueryParser configuration.
Koha would just fallback to not using it.
This patch adds a check for QueryParser configuration sanity in about.pl
To test:
- Have UseQueryParser = "Don't try"
- Go to More > About Koha > System information
- No QueryParser-related warnings
- Set UseQueryParser = "Try"
- Go to More > About Koha > System information
- On a normal setup you shouldn't have any QueryParser-related warnings
- Edit your koha-conf.xml file and change the queryparser_config entry to a
non-existent filename.
- Reload More > About Koha > System information
=> SUCCESS: a warning message tells you the filename used, and says it failed.
- Now just delete the entry in koha-conf.xml
- Reload More > About Koha > System information
=> SUCCESS: a warning message tells you don't have the queryparser_entry in
your koha-conf.xml file.
Subtest:
a - The file /etc/koha/searchengine/queryparser.yaml exists:
=> SUCCESS: a warning saying it used a fallback is shown
b - The file doesn't exist
=> SUCCESS: Missing entry warning, plus a failure message for the fallback.
- Sign off :-D
Regards
To+
Sponsored-by: Universidad Nacional de Cordoba
Followed test plan. Works as expected.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
With the typo in the path (non existing file), 'no warnings' is stil shown
below the warnings. The follow-up fixes that.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Reports.pm | 11 +--
about.pl | 29 +++++++
admin/auth_subfields_structure.pl | 32 +++-----
koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 79 +++++++++++++-------
.../en/modules/admin/auth_subfields_structure.tt | 62 +++++++++------
.../intranet-tmpl/prog/en/modules/circ/offline.tt | 8 +-
.../prog/en/modules/reports/acquisitions_stats.tt | 24 +++++-
.../prog/en/modules/reports/bor_issues_top.tt | 10 ++-
.../prog/en/modules/reports/borrowers_out.tt | 28 ++++++-
.../prog/en/modules/reports/borrowers_stats.tt | 28 ++++++-
.../prog/en/modules/reports/cat_issues_top.tt | 28 ++++++-
.../prog/en/modules/reports/catalogue_stats.tt | 10 ++-
.../prog/en/modules/reports/issues_avg_stats.tt | 24 +++++-
.../prog/en/modules/reports/issues_stats.tt | 28 ++++++-
.../prog/en/modules/reports/reserves_stats.tt | 28 ++++++-
.../prog/en/modules/reports/serials_stats.tt | 28 ++++++-
reports/borrowers_out.pl | 8 +-
reports/borrowers_stats.pl | 7 +-
reports/cat_issues_top.pl | 8 +-
reports/catalogue_stats.pl | 8 +-
reports/issues_stats.pl | 8 +-
reports/reserves_stats.pl | 10 +--
reports/serials_stats.pl | 7 +-
23 files changed, 352 insertions(+), 161 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list