[koha-commits] main Koha release repository branch master updated. v3.16.00-449-g59fc1f5

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  59fc1f5b4106a312d3d1e75d127e6c5a19373075 (commit)
       via  0deb4908a24c03c03cc9a7a0353f47a947648852 (commit)
       via  cd8ca4717c8ee3055a36497db20f263832c83659 (commit)
      from  8f68dad1f2a872fc30b579180c6a5a415cdd77a1 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 59fc1f5b4106a312d3d1e75d127e6c5a19373075
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date:   Sat Jul 12 14:22:53 2014 +0200

    Bug 8539: Library transfer limits page has incorrect permission
    
    Without this patch the library transfer page required the
    'borrowers' permission, which is not quite right for a page
    in the administration module.
    
    This patch changes the permission to 'parameters_remaining_permissions'
    
    To test:
    Verify the page is accessbile with:
    - superlibrarian
    - administration (full)
    - administration, remaining permissions (without manage_circ_rules)
    Verify the page is not accessible without all of those permissions.
    
    Signed-off-by: Nick Clemens <nick at quecheelibrary.org>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 0deb4908a24c03c03cc9a7a0353f47a947648852
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Sun Aug 17 18:44:04 2014 -0400

    Bug 4162 - Followup: only count potential barcodes
    
    The $lines_read++; was before the code which skipped empty
    lines. By moving it after the next unless $barcode; code, the
    $lines_read variable only counts potential barcodes, and does
    not include empty lines.
    
    TEST PLAN
    ---------
    1) Apply patch.
    2) Attempt a valid barcode file with empty lines.
       -- The potential barcode count should exclude the empty lines.
    
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Empty lines are now no longer counted as potential barcodes.
    Passes tests and QA script.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit cd8ca4717c8ee3055a36497db20f263832c83659
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Sat Jul 12 09:42:52 2014 -0400

    Bug 4162 The inventory tool lacks validation for barcodes
    
    The inventory tool had no form of validating on what was assumed
    to be a valid barcode number.
    
    To solve this, an extra loop to read before processing was added.
    This allows to validate length and content. By using a check
    of \p{Print}, this includes Unicode characters such as umlauts,
    but excludes unusual control characters.
    
    The template was modified to accomodate validation messages
    related to the length and content errors. Additionally, it says
    how many "barcodes" were read. Barcodes are supposed to be on
    separate lines.
    
    TEST PLAN
    ---------
    1) Attempt to select a file which does not contain barcodes and
       is not a text file.
       -- a horrible lack of validation and spamminess ensues.
    2) Apply patch
    3) Create three files.
       a) One containing valid barcodes on each line
          -- this file should trigger no errors. Attempt a valid
             barcode with an umlaut.
       b) A copy of the first with an extra line of >20 characters
          (e.g. The Quick Red Fox Jumped Over The Brown Fence^A^B^C)
          -- this file should trigger the singular error message case.
             ^A^B^C are actually CTRL-A,CTRL-B,CTRL-C, and it is left
             as an exercise to the reader to add them to the line.
       c) A copy of the second with the last line duplicated
          -- this file should trigger the plural error message case.
    4) Attempt each of the three files.
    5) Run koha-qa tools.
    
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    
    I have a feeling that the column size could be better fetched from
    Koha::Database. But it is an improvement in functionality signing off
    
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Works as described, no problems found.
    Passes tests and QA script.
    
    Another thing for another day:
    Empty lines are counted for the potential barcodes.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    Works as expected, tried with arab strings, umlauts and no regressions found.

-----------------------------------------------------------------------

Summary of changes:
 admin/branch_transfer_limits.pl                    |    2 +-
 .../prog/en/modules/tools/inventory.tt             |    7 ++++-
 tools/inventory.pl                                 |   32 ++++++++++++++++++++
 3 files changed, 39 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository