[koha-commits] main Koha release repository branch master updated. v3.16.00-481-g7b24c08
Git repo owner
gitmaster at git.koha-community.org
Tue Aug 26 15:30:42 CEST 2014
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 7b24c082bac723a439e26d13bb0b50446e0e80b2 (commit)
via 1e35ea33b0a467aa063e169ab77c70a58e8cbc2a (commit)
via 7832e7db68d8106b0a76e6568c6f83d1bb174558 (commit)
via f590ad7734e767e107b62ebec7ccc9172824f229 (commit)
via 90becc2d2e436b5cf4c7b467b3c69549c90c7949 (commit)
via b77a1c794f541c18598afc6095ea87d7c247d80a (commit)
via 1108f2407d205522f0a3e3046de169fa76021e55 (commit)
via 23ccb9fd1781b482fe747d513b490a1e5b364203 (commit)
via 9f1218ce4f22f3a9661ebfcf56f792c29dea96f7 (commit)
via 2164bfccd82bb3705f32f8b9c4b171c985b8d2e2 (commit)
via 48b50b1d133d86720f35fa691ae5e18799cee26b (commit)
via ebf4e33cbfdee92b4c485c7e51e1aaea273c1f39 (commit)
from 68bcac15d8eb43fd1c1529dc86f834431a8c77ce (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 7b24c082bac723a439e26d13bb0b50446e0e80b2
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Fri Aug 22 12:26:54 2014 -0300
Bug 12808: remove useless diags from t/db_dependent/Context.t
Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 1e35ea33b0a467aa063e169ab77c70a58e8cbc2a
Author: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Date: Mon Aug 11 00:23:52 2014 -0300
Bug 12222: members-update.tt has a giant hash variable
This patch changes that giant hash by a TT block
to find apropriate strings
To test:
1) Apply the patch
2) On opac log as some user and request some modifications
on personal data
3) On staff, reload main, will see a notice that a patron
has requested modification, clic on the link
4) All modified data must show with apropriate legends
for each db column, check for regressions
5) Update translation files for your preferred language, xx-YY
Check for new strings, e.g.
egrep "Alternate address" misc/translator/po/xx-YY*
You must find old and new instances
(old with #~ , in particular the hash one)
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Works as advertised, strings are now translatable.
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
I like to have this fixed. I'd like it to use C4::Templates::GetColumnDefs
instead, but it belongs to another bug report I guess.
commit 7832e7db68d8106b0a76e6568c6f83d1bb174558
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Tue Aug 26 10:18:02 2014 -0300
Bug 10212: DBRev 3.17.00.015
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit f590ad7734e767e107b62ebec7ccc9172824f229
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Tue Aug 26 09:57:49 2014 -0300
Bug 10212: (qa followup) accordion collapsed by default
By default, the accordion shows the first element (Acquisitions) which
is empty, and missleading. This patch collapses it by default.
The expected behaviour is that if we are rendering because the user saved
its changes, the modified accordion should be expanded, so I added a test
for the $panel variable.
Template comment added for future references about it.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 90becc2d2e436b5cf4c7b467b3c69549c90c7949
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Tue Jul 22 10:21:53 2014 +0200
Bug 10212: Use the update_or_create DBIC method when possible
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit b77a1c794f541c18598afc6095ea87d7c247d80a
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Fri Jul 18 15:22:06 2014 +0200
Bug 10212: Move colvis files to the include file
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes all tests and QA script.
Implements the option to change the default columns that appear in
a table while giving the user the option to change the columns
individually for a session.
As an example, this feature is implemented for the currencies table.
Works well for all possible combinations in configuration.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 1108f2407d205522f0a3e3046de169fa76021e55
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Tue Jul 15 18:07:35 2014 +0200
Bug 10212: Add Colvis to the about page
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 23ccb9fd1781b482fe747d513b490a1e5b364203
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Mon Jul 7 13:08:13 2014 +0200
Bug 10212: Columns configuration for tables - POC
This patch proves that this feature is useful with a concret use case.
Test plan:
1/ Execute the updatedatabase in order to create the new table.
2/ Take a look to the yml structure.
3/ Go on the admin currency page (admin/currency.pl).
4/ Check that you cannot hide the 2 first columns on the table.
5/ Try to hide/show columns.
6/ Go on the columns configuration page (admin/columns_settings.pl).
7/ Only the admin tab are filled with data. Check/uncheck checkboxes and
save.
8/ Go on the admin currency page and check that the behavior is what
you expected.
9/ Give me some feedback :)
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 9f1218ce4f22f3a9661ebfcf56f792c29dea96f7
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Tue May 7 14:07:49 2013 +0200
Bug 10212: Columns configuration for tables - Add Colvis files
This patch only adds Colvis js and css files.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 2164bfccd82bb3705f32f8b9c4b171c985b8d2e2
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Fri Jan 10 18:26:27 2014 +0100
Bug 10212: Columns configuration for tables - Unit tests
test plan:
Verify the
prove t/db_dependent/ColumnsSettings.t
returns green.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 48b50b1d133d86720f35fa691ae5e18799cee26b
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Mon Jul 7 13:16:08 2014 +0200
Bug 10212: Columns configuration for tables - DB changes
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit ebf4e33cbfdee92b4c485c7e51e1aaea273c1f39
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Mon Jul 7 10:28:21 2014 +0200
Bug 10212: Columns configuration for tables
This development introduces ColVis into Koha and provides a configuration
page for columns visibility.
ColVis is a plugin for DataTables. It allows to change the visibility of
the columns in the table.
* This development adds:
- the js and css file for ColVis
- a new DB table 'columns_settings'
- a new template plugin 'ColumnsSettings'
- a new package C4::Utils::DataTables::ColumnsSettings
- a new admin page admin/columns_settings.pl
* How it works:
A yaml file is created (admin/columns_settings.yml) in order to take an
inventory of all tables where ColVis is implemented. This file is read
to create the list of modules, pages and tables in the configuration
page.
There are 3 possible keys in the yml:
- is_hidden: default is 0
The column will be hidden.
- cannot_be_toggled: default is 0.
ColVis will allow to hide/show the column.
- cannot_be_modified: default is 0
Default values (in the yml) won't be modifiable.
When a user changes (or saves) the configuration for one module, all
columns are added to the DB table. The values in the DB get the upper hand
on the yaml values.
* Humm, strange?
It seems weird to have 2 storages for the same values. But I
think it will be easy to add an entry and maintain the yaml rather than
adding a new row (and new entry in updatedatabase script) in the DB.
* To go further: We can imagine that the configuration is saved for each
user (and not globally like it is made with this patch).
This patch cannot be tested as it, you need to apply the "POC" patch.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes all tests and QA script, more comments on last patch.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Utils/DataTables/ColumnsSettings.pm | 83 ++
Koha/Schema/Result/ColumnsSetting.pm | 103 ++
Koha/Template/Plugin/ColumnsSettings.pm | 55 ++
admin/columns_settings.pl | 62 ++
admin/columns_settings.yml | 23 +
installer/data/mysql/kohastructure.sql | 14 +
installer/data/mysql/updatedatabase.pl | 17 +
.../lib/jquery/plugins/jquery.dataTables.colvis.js | 1013 ++++++++++++++++++++
.../prog/en/css/datatables.colvis.css | 76 ++
.../intranet-tmpl/prog/en/includes/admin-menu.inc | 1 +
.../prog/en/includes/columns_settings.inc | 30 +
koha-tmpl/intranet-tmpl/prog/en/js/datatables.js | 2 +-
koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 4 +
.../prog/en/modules/admin/admin-home.tt | 2 +
.../prog/en/modules/admin/columns_settings.tt | 154 +++
.../prog/en/modules/admin/currency.tt | 43 +-
.../prog/en/modules/members/members-update.tt | 108 ++-
kohaversion.pl | 2 +-
t/db_dependent/ColumnsSettings.t | 179 ++++
t/db_dependent/Context.t | 8 +-
20 files changed, 1907 insertions(+), 72 deletions(-)
create mode 100644 C4/Utils/DataTables/ColumnsSettings.pm
create mode 100644 Koha/Schema/Result/ColumnsSetting.pm
create mode 100644 Koha/Template/Plugin/ColumnsSettings.pm
create mode 100755 admin/columns_settings.pl
create mode 100644 admin/columns_settings.yml
create mode 100644 koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery.dataTables.colvis.js
create mode 100644 koha-tmpl/intranet-tmpl/prog/en/css/datatables.colvis.css
create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc
create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt
create mode 100644 t/db_dependent/ColumnsSettings.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list