[koha-commits] main Koha release repository branch 3.14.x updated. v3.14.11-16-g67d8f68

Git repo owner gitmaster at git.koha-community.org
Mon Dec 15 17:44:50 CET 2014


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.14.x has been updated
       via  67d8f680f2d82a4a4540f2337d15ff9faa8e24e7 (commit)
      from  c0d4b8f9c880bb11f0ab1187752c2f0cb5f22bac (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 67d8f680f2d82a4a4540f2337d15ff9faa8e24e7
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Wed May 21 07:14:50 2014 -0400

    Bug 12025 - Inventory tool fails with "Could not reads headers", or sometimes a timeout
    
    For libraries with large numbers of records, using a file of barcodes in
    the inventory tool without selecting filters to limit the catalog
    selection to compare against can result in an error of "could not read
    headers" or a page timeout.
    
    When you upload a file of barcodes, and do not specify any filters on
    the rest of the form, it effectively runs GetItemsForInventory() such
    that *every* item in the database is returned.  On a large enough
    database, this takes so long that the script times out.
    
    The current documentation in the manual implies that if you upload a
    file of barcodes, the *only* thing it does is set the date-last-seen
    field.  This is not entirely true; it also tries to compare the list of
    scanned items to what is expected to be seen in the list of items.
    
    The work-around for libraries with a large number of item records is to,
    when uploading a file of barcodes, to also set the filters (e.g.,
    library, shelving location, call number range, etc.) to
    specify the range of items that the file of barcodes corresponds to.
    
    This patch adds a warning when a librarian attempts to upload a
    barcode list file for comparison without selecting any filters
    to limit the catalog selection.
    
    Test Plan:
    1) Apply this patch
    2) Browse to the inventory tool
    3) Click the "Choose File" button, select a file
    4) Click the "Submit" button
    5) You should see a warning message
    6) Click "Cancel"
    7) Select one of more filters
    8) Click the "Submit" button
    9) This time the script should proceed without triggering the warning.
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Work as described following test plan.
    No errors
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 4b9409863eab03072212308e386b3dd622eb9b46)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-----------------------------------------------------------------------

Summary of changes:
 .../prog/en/modules/tools/inventory.tt             |   29 +++++++++++++++-----
 1 file changed, 22 insertions(+), 7 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list