[koha-commits] main Koha release repository branch 3.18.x updated. v3.18.02-25-g903a08a

Git repo owner gitmaster at git.koha-community.org
Mon Dec 29 20:17:46 CET 2014


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.18.x has been updated
       via  903a08a4f85a70f8c2a03fb6795cefdc92716e5a (commit)
       via  5296fe954512022adb754c6cfa5bcad0ba8cb609 (commit)
       via  5e707555f88edb5beb2c63e0dbcef698907e44d6 (commit)
       via  54a37c8fc1c1ac8db0d4127b0daa7dc588c9a59f (commit)
      from  71f1c5ef820c7d492e4ce932fcbeebc0fcbfb2e1 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 903a08a4f85a70f8c2a03fb6795cefdc92716e5a
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Nov 20 11:01:08 2014 -0500

    Bug 1861 [QA Followup] - Don't modify userids, warn if we can't modify the index automatically
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 179ef0f28f7216231a07adb69fc0f3e1e4858d1a)
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

commit 5296fe954512022adb754c6cfa5bcad0ba8cb609
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Mon Nov 3 07:38:48 2014 -0500

    Bug 1861 [QA Followup] - Fix Check_Userid and unit tests
    
    Check_Userid assumes that a borrowernumber will always be passed in
    and thus fails to to return 0 for an already used userid when creating
    a new patron.
    
    Unit tests must now also me modified to no longer assume it is possible
    to create multiple patrons with the same userid.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    (cherry picked from commit 7135364dd23442c38bed986b2540ab63cfd06ce1)
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

commit 5e707555f88edb5beb2c63e0dbcef698907e44d6
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Tue Jul 8 09:50:08 2014 -0400

    Bug 1861 - Unique patrons logins not (totally) enforced
    
    The Koha 3.0 patron admin page will prevent you from creating a user who
    has an identical OPAC login as someone else (though I would change the
    error message from "Login/password already exists." to "Login
    already exists.", since it's not the password that's the
    problem).
    
    However, there's nothing enforced in the MySQL database to prevent
    patrons from being imported or manually inserted with duplicate logins.
    Would it be better to change the MySQL spec from this:
    KEY `userid` (`userid`)
    to this:
    UNIQUE KEY `userid` (`userid`)
    
    Test plan:
    1) Enter mysql console
    2) Attempt to create two borrowers with identical user id's
    3) Note you are able to do so
    4) Delete these bororwers
    5) Apply this patch
    6) Run updatedatabase.pl
    7) Repeat step 2
    8) Note you are now unable to do so
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Work as described, no koha-qa errors
    
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Leaves deletedborrowers as it is, deleting patrons still works ok.
    Works according to test plan.
    Database update will only be successful, when no duplicate entries
    exist in the database.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    (cherry picked from commit df4297621d285dbdbe13eaff04dae2a9419ed824)
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

commit 54a37c8fc1c1ac8db0d4127b0daa7dc588c9a59f
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Mon Nov 3 12:29:48 2014 -0500

    Bug 13017 - Login page image replacement technique fails when browser width exceeds 2000 pixels
    
    This patch updates the image replacement technique used for Koha's login
    page. The old technique used a negative text-indent value to move the
    text offscreen, but that begins to fail more and more often as screens
    get larger.
    
    The new technqiue is described here:
    http://www.zeldman.com/2012/03/01/replacing-the-9999px-hack-new-image-replacement/
    
    Note: This patch has not been tested in any Internet Explorer version!
    
    To test you must have a screen which is wider than 2000 pixels. Apply
    the patch, clear your browser cache and view the staff client login
    page. The logo on the login form should look correct with no
    corresponding text appearing anywhere on the screen.
    
    Signed-off-by: Christopher Brannon <cbrannon at debian.localdomain>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    (cherry picked from commit 87a0b79a65f179fdef5aee98701660cca00a273e)
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

-----------------------------------------------------------------------

Summary of changes:
 C4/Members.pm                                 |   31 ++++++++++++++-----------
 installer/data/mysql/kohastructure.sql        |    2 +-
 installer/data/mysql/updatedatabase.pl        |   20 ++++++++++++++++
 koha-tmpl/intranet-tmpl/prog/en/css/login.css |    6 +++--
 t/db_dependent/Members.t                      |   13 +++++------
 5 files changed, 48 insertions(+), 24 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list