[koha-commits] main Koha release repository branch master updated. v3.18.00-85-ga93fd3f

Git repo owner gitmaster at git.koha-community.org
Wed Dec 31 20:46:34 CET 2014


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  a93fd3fe06dbdea972ea8c329ae4f77335314566 (commit)
       via  469f36d38fe3ea82013d40b95892dfb7605b4e5f (commit)
       via  ba2527310866958635d807880d07d8f1b3cb4d0a (commit)
       via  104fc792f5aab8305de685f743e3e6b1cb64adaa (commit)
       via  cfce425771350912c3cd8e21c8e205d776aaa443 (commit)
       via  a43e6d26f64a9ee46de4f7de917c63fad3a971c2 (commit)
       via  426a48dd19c5d3cfd5296b236b4e86f9130e1001 (commit)
       via  fb706f58b23ba815f9b372f06fe5aafbb8cd52c5 (commit)
       via  a847067d7ef5350f9572c92407971baa7af76216 (commit)
      from  ee02bcb14f30a897c1e3eeac3933ba83dacf3abe (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a93fd3fe06dbdea972ea8c329ae4f77335314566
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Thu Nov 6 10:45:42 2014 +0100

    Bug 12896: Remove 2 occurrences in comments
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Passes tests and QA script.
    Full test report on the bug report.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 469f36d38fe3ea82013d40b95892dfb7605b4e5f
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Tue Sep 9 15:56:56 2014 +0200

    Bug 12896: Move the bookseller-related code into Koha::Acquisition::Bookseller
    
    The C4::Acquisition module should be exploded in order to add
    readability and maintainability to this part of the code.
    
    This patch is a POC, it introduces a new Koha::Acquisition::Bookseller module and put in
    it the code from GetBookSeller and GetBookSellerFromId.
    
    Test plan:
    1/ Create a bookseller, modify it.
    2/ Add contacts for this bookseller
    3/ Create an order, receive it, transfer it
    4/ Launch the prove command on all unit tests modified by this patch and
    verify that all pass.
    
    Signed-off-by: Paola Rossi <paola.rossi at cineca.it>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit ba2527310866958635d807880d07d8f1b3cb4d0a
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Tue Aug 26 11:14:33 2014 +0200

    Bug 12823: Alert about defining the SRU search field mappings
    
    This is a follow-up for report 6536 (SRU search targets).
    It will alert a user that saves a SRU server without field mappings.
    
    Test plan:
    Add a Z39.50 server. No confirm message.
    Add a SRU server without field mappings. Cancel the confirm.
    Add one field mapping. No confirm message.
    
    Signed-off-by: Nick Clemens <nick at quecheelibrary.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 104fc792f5aab8305de685f743e3e6b1cb64adaa
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Tue Aug 26 10:31:29 2014 +0200

    Bug 12823: Add some hints for Host and Database
    
    When adding or editing a SRU server, this patch adds a hint, positioned
    under the Hostname field.
    It also moves similar information for SRU options and XSLT into hints.
    
    Test plan:
    Add/Edit SRU server. Look at Hostname, SRU options and XSLT.
    Add/Edit Z39.50 server. No hints for Hostname and SRU options.
    
    Signed-off-by: Nick Clemens <nick at quecheelibrary.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit cfce425771350912c3cd8e21c8e205d776aaa443
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Wed Dec 31 14:09:00 2014 -0300

    Bug 1861: (RM followup) DNIx updates
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit a43e6d26f64a9ee46de4f7de917c63fad3a971c2
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Wed Dec 31 12:09:49 2014 +0100

    Bug 13502: Add tests to highlight the problem
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 426a48dd19c5d3cfd5296b236b4e86f9130e1001
Author: Chris Cormack <chrisc at catalyst.net.nz>
Date:   Wed Dec 31 10:20:59 2014 +1300

    Bug 13502: Code introcduced in 1861 wrongly assumes a null userid is unique
    
    To test
    
    1/ Create a borrower with '' as their userid, you may have to edit a
       row in the db to do this
    2/ Run  perl t/db_dependent/Circulation/CheckIfIssuedToPatron.t
    3/ Notice some tests fail and you see
       DBD::mysql::st execute failed: Duplicate entry '' for key 'userid'
       at /home/chrisc/git/catalyst-koha/C4/SQLHelper.pm line 184.
    4/ Apply the patch
    5/ Run the tests again, notice they now pass
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit fb706f58b23ba815f9b372f06fe5aafbb8cd52c5
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Tue Dec 30 09:51:32 2014 +0100

    Bug 1861: Add 1 test to AddMember
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit a847067d7ef5350f9572c92407971baa7af76216
Author: Chris Cormack <chrisc at catalyst.net.nz>
Date:   Tue Dec 30 15:37:39 2014 +1300

    Bug 1861: There is a problem introduced with an earlier patch, on this patchset
    
    -    $data{'userid'} = Generate_Userid($data{'borrowernumber'},
    $data{'firstname'}, $data{'surname'}) if $data{'userid'} eq '';
    +    $data{'userid'} = Generate_Userid( $data{'borrowernumber'},
    $data{'firstname'}, $data{'surname'} )
    +      if ( $data{'userid'} eq '' || Check_Userid( $data{'userid'} ) );
    
    Check_Userid returns 1 if it is unique.  So this means unique userids
    will always be discarded and new ones created.
    
    This is why all the tests depending on a userid are now failing
    
    To test
    
    1/ run perl t/db_dependent/Serials_2.t
    2/ Notice lots of tests fail
    3/ OR Add a borrower with a userid set, notice the userid is ignored
    and one is generated instead
    4/ Apply patch
    5/ Add a new borrower, notice the userid sticks (if it is unique)
    6/ Run perl t/db_dependent/Serials_2.t notice tests pass
    7/ Run perl t/db_dependent/Members.t notice tests still pass
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Acquisition.pm                                  |    4 +-
 C4/Bookseller.pm                                   |   53 +--------
 C4/Members.pm                                      |    4 +-
 Koha/Acquisition/Bookseller.pm                     |  124 ++++++++++++++++++++
 Koha/Schema/Result/Borrower.pm                     |   16 ++-
 acqui/addorderiso2709.pl                           |    4 +-
 acqui/basket.pl                                    |    5 +-
 acqui/basketgroup.pl                               |   10 +-
 acqui/basketheader.pl                              |    6 +-
 acqui/booksellers.pl                               |    7 +-
 acqui/finishreceive.pl                             |    5 +-
 acqui/invoice.pl                                   |    5 +-
 acqui/invoices.pl                                  |    3 +-
 acqui/modordernotes.pl                             |    5 +-
 acqui/neworderbiblio.pl                            |    5 +-
 acqui/neworderempty.pl                             |    5 +-
 acqui/newordersubscription.pl                      |    5 +-
 acqui/newordersuggestion.pl                        |    5 +-
 acqui/orderreceive.pl                              |    5 +-
 acqui/parcel.pl                                    |    6 +-
 acqui/parcels.pl                                   |    5 +-
 acqui/supplier.pl                                  |    6 +-
 acqui/transferorder.pl                             |   11 +-
 acqui/uncertainprice.pl                            |    5 +-
 acqui/z3950_search.pl                              |    5 +-
 admin/aqcontract.pl                                |    5 +-
 catalogue/moredetail.pl                            |    5 +-
 .../prog/en/modules/admin/z3950servers.tt          |   11 +-
 serials/acqui-search-result.pl                     |    5 +-
 serials/subscription-detail.pl                     |    8 +-
 t/db_dependent/Acquisition.t                       |    7 +-
 t/db_dependent/Acquisition/Invoices.t              |    8 +-
 t/db_dependent/Acquisition/OrderFromSubscription.t |    4 +-
 t/db_dependent/Bookseller.t                        |   94 ++++++++-------
 t/db_dependent/Letters.t                           |    7 +-
 t/db_dependent/Members.t                           |   20 +++-
 36 files changed, 309 insertions(+), 179 deletions(-)
 create mode 100644 Koha/Acquisition/Bookseller.pm


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list