[koha-commits] main Koha release repository branch master updated. v3.14.00-404-g94e349f

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  94e349ff6ce4a1abb313102decc12429d02dfb4b (commit)
       via  03d4ed2468bb9ab97b1f7b7d9e29507dc815a8b3 (commit)
       via  939079de756fdda1ca8f62c48efe0e2e3034ae32 (commit)
       via  7baf02c263a627b1454577b3141a0af4b8f963d1 (commit)
       via  d1b6e0646fd6a70f6724189554e80aaa68aec64b (commit)
      from  547ebaece0bcd24857cecd6c95d8a5c1c41ce222 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 94e349ff6ce4a1abb313102decc12429d02dfb4b
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Tue Feb 4 23:03:08 2014 +0000

    Bug 11666: remove SQL as an option for MARC framework exports and imports
    
    The SQL option for MARC framework imports was subject to a bug whereby
    somebody could use it to gain access to arbitrary information in the
    database by uploading an SQL file containing unexpected statements.
    
    As it is difficult to securely sanitize SQL, this patch removes the
    option to use SQL as an import or export format.
    
    To test:
    
    [1] Verify that SQL no longer appears as an import or export option
        for the MARC frameworks.
    [2] Verify that exports and imports in CSV, Excel XML, and ODS formats
        still work.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    Works as advertised. The UI doesn't offer exporting/importing in the SQL format.
    Crafting the URL to export SQL fallbacks to a spreadsheet format (ODS).
    
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Works as described, passes all tests and QA script.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 03d4ed2468bb9ab97b1f7b7d9e29507dc815a8b3
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Tue Feb 4 15:54:33 2014 +0000

    Bug 11666: add permission check for MARC framework import/export
    
    This patch makes the MARC framework import/export script require
    that the staff user be logged in with appropriate permissions for
    managing the MARC frameworks.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    
    I can confirm the bug and the solution. After applying the patch
    downloading the file without logging in first is no longer possible.
    Also passes tests and QA script.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 939079de756fdda1ca8f62c48efe0e2e3034ae32
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Sat Feb 1 02:11:38 2014 +0000

    Bug 11662: remove disused member-picupload.pl
    
    This script is no longer used, and in addition has problematic
    handling of its parameters that could lead to writing to
    arbitrary files on the server.
    
    To test:
    
    [1] Verify that member-picupload.pl is no longer referred
        to in the codebase after applying this patch.
    [2] Verify that there are no regressions in patron
        photo management.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Found no regressions in removing this script.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 7baf02c263a627b1454577b3141a0af4b8f963d1
Author: Chris Cormack <chris at bigballofwax.co.nz>
Date:   Sat Feb 1 15:06:58 2014 +1300

    Bug 11661: sanitize file names supplied to edithelp.pl
    
    This patch corrects an issue whereby edithelp.pl could
    be used to create or modify arbitrary files on the server
    with the permissions of the Apache user.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit d1b6e0646fd6a70f6724189554e80aaa68aec64b
Author: Chris Cormack <chris at bigballofwax.co.nz>
Date:   Sat Feb 1 14:18:23 2014 +1300

    Bug 11660: remove disused tools/pdfViewer.pl
    
    tools/pdfViewer.pl can be used to read artibrary files on the system.
    
    It is actually an unused file, so leaving it around serves no purpose
    and is dangerous.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    No regressions found.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/ImportExportFramework.pm                        |  219 +-------------------
 admin/import_export_framework.pl                   |   26 ++-
 edithelp.pl                                        |    4 +-
 .../prog/en/modules/admin/biblio_framework.tt      |   16 +-
 members/member-picupload.pl                        |   77 -------
 tools/pdfViewer.pl                                 |   42 ----
 6 files changed, 42 insertions(+), 342 deletions(-)
 delete mode 100755 members/member-picupload.pl
 delete mode 100755 tools/pdfViewer.pl


hooks/post-receive
-- 
main Koha release repository