[koha-commits] main Koha release repository branch 3.12.x updated. v3.12.10-21-ge3a0cbc
Git repo owner
gitmaster at git.koha-community.org
Fri Feb 7 16:32:17 CET 2014
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 3.12.x has been updated
via e3a0cbc1ace403bbf9ebf5c5e7a8fa735e7fdf38 (commit)
via 8e08bcae90140f733552fc57acd5c5fba5d72080 (commit)
via aad3a40dfa7c31bbe2d13bd4d7ed49822c30c9c4 (commit)
via f09115dea10ee0472c0eb6373689efe8cf31ffc4 (commit)
via afec6faccc58978158ebe31ac85a96ac7c1308a0 (commit)
via e1b1dceabb52e72c6b899e625f7e9308aba8f15b (commit)
via 6b09a1c19558d58fd3d1d323f89416455fda5706 (commit)
via b088664b1f6a2811ea52f4e2eb825786d4c0e2d8 (commit)
via 59d3dcb508a4f3be750e79797254f43bf5e1fae9 (commit)
via bff00739703bd38951b171078f0413d3413705fe (commit)
via cc71930a84761177279554dc467e23bf9d736f62 (commit)
via 87079a0aa149b67b064bfdbb8eb603fa60a260fb (commit)
via e3bf3e4521fa09a0d5dddcbb083282ec9c8e04b8 (commit)
from cc4a2a641ed9d662afbf188b418cc62f41b4cdc3 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit e3a0cbc1ace403bbf9ebf5c5e7a8fa735e7fdf38
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Tue Jan 14 11:35:31 2014 -0300
Bug 11540: (follow-up) add a couple of tests more
This patch makes sure all scenarios are covered for SetUTF8Flag.
Signed-off-by: Emma Heath <emmaheath.student at wegc.school.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
(cherry picked from commit 0db732980aec0e7f7257b559419781adfab538ed)
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 8e08bcae90140f733552fc57acd5c5fba5d72080
Author: Emma Heath <emmaheath.student at wegc.school.nz>
Date: Tue Jan 14 14:18:47 2014 +1300
Bug 11540: increase test coverage of Charset.pm
To test
1. run prove t/Charset.t
2. apply patch
3. run prove t/Charset.t
notice more tests are run
Signed-off-by: Tom Houlker <thomas.houlker at hibs.school.nz>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Tests pass!
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
(cherry picked from commit 6a6df3f5d755aa462f727fa21464883b31d51462)
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit aad3a40dfa7c31bbe2d13bd4d7ed49822c30c9c4
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Wed Jan 15 21:06:04 2014 -0300
Bug 9579: fix truncation of facets containing multi-byte characters
We seem to be relying on whatever Zoom::Results->render return, and
Perl doesn't explicitly consider it UNICODE data. That's why CORE::substr
(and probably CORE::length too) cut the bytes wrong.
This patch just decodes the UTF-8 data that render() returns and then
Perl behaves, heh.
It uses Encode::decode_utf8 which is already a dependency for the current
stable Koha releases.
REVISED TEST PLAN
-----------------
1) Import the attached sample records.
2) Rebuild your indexes
3) In OPAC search for يكيمكتبات : قبسي ، كرم
-- There will be ugly diamonds with question marks in the facets
4) apply the patch
5) Search again.
-- The names will be properly truncated.
NOTE: This test assumes FacetLabelTruncationLength = 20.
Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes all tests and QA script.
Works as described, tested with several German, English and
the Arabic test record. Arabic strings now display correctly
and no regression was found.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
I've reviewed it and approve its inclusion in 3.14.x and earlier. I
will use the patches for bug 11096, once they pass QA, for the master
branch.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit 171e2b47460c7afa489b16eb885a9862eef9d43a)
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit f09115dea10ee0472c0eb6373689efe8cf31ffc4
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Mon Dec 16 12:01:21 2013 +0100
Bug 11398: A typo occurred with occured
This patch cures occured and makes occurred occur.
Note that I found them while testing bug 11170.
In a follow-up of 11170, I corrected this typo in parcels.tt.
This patch touches update22to30.pl and modborrowers.tt
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Fixes a typo in 2 files.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
(cherry picked from commit 9921228f2a12de47d8e1fc85e936562c20a7abe4)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit f69e836569ee122ca42d6bf77ebac9dd656f55e5)
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit afec6faccc58978158ebe31ac85a96ac7c1308a0
Author: Galen Charlton <gmc at esilibrary.com>
Date: Mon Dec 30 16:22:05 2013 +0000
Bug 11402: (follow-up) add one more unit test
This test exercise the case where defined parameters
are passed to the _guide_box() routine.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
(cherry picked from commit 7d01e61cdf96f06d3f823eaaa435e2850bacf7e4)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit ef6eeba806fcea5e9cab652f425546de90147285)
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit e1b1dceabb52e72c6b899e625f7e9308aba8f15b
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Mon Dec 16 11:55:56 2013 -0300
Bug 11402: make Labels::_guide_box return undef if undefned data is passed
That's it. A guide box cannot be created if invalid data is passed.
Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes all tests and QA script, includes new unit tests.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
(cherry picked from commit 4720cbc4145223f1ffd653efdefd1a4f724d3144)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit c129755ce41fcc3712c987149d5cbc4dec696cf6)
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 6b09a1c19558d58fd3d1d323f89416455fda5706
Author: Magnus Enger <magnus at enger.priv.no>
Date: Sat Nov 23 22:57:03 2013 +0100
Bug 11188 - Make gather_print_notices.pl die on failed open()
Problem:
If you tell gather_print_notices.pl to write output to a location
you do not have write access to, it will silently fail to write the
data, but still mark unsent messages as sent.
Solution:
This patch adds two lines of defense:
1. Check that the location given for the output is writable
2. use "open() or die" instead of just "open()" when writing the
output
The first measure should catch most of the potential errors, but
I guess a directory can be writable, but the open() still can fail
because the disk is full or something similar.
To test:
- Make sure you have some unsent messages in the message_queue table,
that do not have an email adress
- Apply the patch
- Run the script, pointing at a location you do not have access to
write to. Check that the script exits with an appropriate error
message, and that the unsent messages are still unsent. Do this
both with and without the -s option.
- To fake passing the first line of defence, comment out line 62
and put this in instead:
if ( !$output_directory || !-d $output_directory ) {
- Run the script again as above, check you get an appropriate
error and that the message queue is not touched
- Reset line 62 to how it was
- Run the script against a directory you do have access to write to
and check that output is produced as expected and that messages
are marked as sent
- Sign off
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes all tests and QA script.
Works as described.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
(cherry picked from commit e8a24c35f64cb461a80f768b505bbf16c49dfeff)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit ac5a13eaa34b2377d39b362ed0326f200b5365e5)
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit b088664b1f6a2811ea52f4e2eb825786d4c0e2d8
Author: Gaetan Boisson <gaetan.boisson at biblibre.com>
Date: Wed Dec 18 15:19:50 2013 +0100
Bug 11417: make sure remove_unused_authorities.pl accepts --test
This patches adds support for the --test option, as well as a
short message telling the user the script is running in test mode.
Test plan :
- Launch the script with -h to see the help
- Launch the script with --test and --aut with an authtypecode
that is used in your instance
- Make sure it does the same thing as launching it with -t
- Launch the script for real and make sure it still works as
expected, deleting unused authorities.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
(cherry picked from commit 6657860010ef27792251596590c1471ad5d08ad8)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit f6ab47d2e2039fde60670e7541f030d44dbc6bae)
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 59d3dcb508a4f3be750e79797254f43bf5e1fae9
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Thu Dec 19 11:05:54 2013 +0100
Bug 11279: (follow-up) remove unnecessary check on number of quotes
It is not necessary to process the case where the number of quotes
is just one, as int(rand(1)) will always produce 0, which is a valid
offset.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
(cherry picked from commit 8ee6e4290e2d1ca4fea53363b7ca3275cb0e6f58)
(cherry picked from commit bff4fac7b78fe8573527c8733f8364af351d23a9)
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit bff00739703bd38951b171078f0413d3413705fe
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Thu Dec 12 00:54:08 2013 +0100
Bug 11279: Improve how a new quote of the day is selected
If there is a gap in the id sequence for the quotes table, it
is possible that no new quote will be selected. This will happen
particularly when a lot of the older quotes with low ids have been
deleted.
This patch improves the selection of a new quote.
To test:
- Load sample quotes
- Delete the first half of the quotes.
Note: With 34 quotes, delete the quotes with ids from 1-17
- Activate the QuoteOfTheDay system preference
- Check if a quote is displayed in OPAC
- Reload the page a few times, no quote should be displayed
Note: make sure you don't have a quote with the current
date in your quotes table before running those tests
- Run 'perl t/db_dependent/Koha.t'
Note: requires sample quotes!
- Apply patch
- Reload the OPAC start page
- Verify a quote was now picked
- Run 'perl t/db/dependent/Koha.t' again - all tests should still pass
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Patch modified to use "LIMIT 1 OFFSET ?" rather than "LIMIT ?, 1"; the
latter construction does not work in PostgreSQL.
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
(cherry picked from commit 5a3db23362eb076a2f6d5a87f87b29f4a436a14f)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit ae55277499f06ae0d3e2973349d1f34cf7f60ec8)
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit cc71930a84761177279554dc467e23bf9d736f62
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Thu Dec 12 20:50:52 2013 +0100
Bug 11279: regression test for picking random quote
This patch adds new tests based on the db_dependent tests in
t/db_dependent/Koha.t for GetDailyQuote().
Tests run on an empty database and don't require Test::Deep.
Tests will fail before applying the patch for 11297, but will
pass after applying the patch.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
(cherry picked from commit f874eec0793f83c3c0f1461fecb878ca57ed701b)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit 252051df7378d1d23e726a8757efb4e6af22d1fa)
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 87079a0aa149b67b064bfdbb8eb603fa60a260fb
Author: Fridolyn SOMERS <fridolyn.somers at biblibre.com>
Date: Thu Mar 7 16:02:55 2013 +0100
Bug 7518: certain searches with quotation marks don't work
Under certain circumstance, a search term without quotation marks
returns the expected results while the same search with a
double quote embedded in it would fail.
Koha should ignore the quotation marks and return results anyway.
This appears when QueryWeightFields syspref is activated (and
QueryAutoTruncate is off), as field weighting builds a complex CCL
query using double quotes around search words. This patch simply
replaces double quotes in search words by a space.
Test plan :
- Set QueryAutoTruncate off (you may also need to set QueryFuzzy to off)
- Set QueryWeightFields off
- Perform a serch on two words where you have results, like : centre "ville
=> you get results
- Set QueryWeightFields on
- Perform same serch
=> you get the same results
Signed-off-by: Leila <koha.aixmarseille at gmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
(cherry picked from commit 868855df4b674b495966c022392068c2fdd3a35f)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit f1bb46172bdc90db00a08c2c78e169952fd22feb)
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit e3bf3e4521fa09a0d5dddcbb083282ec9c8e04b8
Author: Galen Charlton <gmc at esilibrary.com>
Date: Tue Dec 17 16:32:09 2013 +0000
Bug 7518: regression test double-quote in search operand
Under certain circumstances, namely where QueryParser is off,
QueryWeightFields is on, and QueryFuzzy and QueryAutoTruncate are
off, a search with a double-quote embedded in it can fail: for
example
web application
would return results where
web "application
does not.
This patch adds an automated regression test.
To test:
[1] Apply this patch and run prove -v t/db_dependent/Search.t;
two tests should fail.
[2] After applying the main patch that fixes the bug, the
prove -v t/db_dependent/Search.t should succeed.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
(cherry picked from commit 437f06624759c464d667107d9f73ec05283f6892)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit 895f989dcaad44830bc85d855d71b654170dbb1d)
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Fixed some conflicts, the tests are they same overall.
-----------------------------------------------------------------------
Summary of changes:
C4/Koha.pm | 23 +++---
C4/Labels/Label.pm | 2 +
C4/Search.pm | 6 +-
installer/data/mysql/update22to30.pl | 2 +-
.../prog/en/modules/tools/modborrowers.tt | 2 +-
misc/cronjobs/gather_print_notices.pl | 15 ++--
misc/migration_tools/remove_unused_authorities.pl | 15 ++--
t/Charset.t | 44 ++++++++++-
t/Labels.t | 26 ++++++-
t/db_dependent/Koha/GetDailyQuote.t | 77 ++++++++++++++++++++
t/db_dependent/Search.t | 20 ++++-
11 files changed, 198 insertions(+), 34 deletions(-)
create mode 100644 t/db_dependent/Koha/GetDailyQuote.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list