[koha-commits] main Koha release repository branch 3.14.x updated. v3.14.03-43-g74fe7c3
Git repo owner
gitmaster at git.koha-community.org
Tue Feb 18 09:56:14 CET 2014
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 3.14.x has been updated
via 74fe7c3eaacf8fb42e1be8b9fd1accc9bb750c08 (commit)
via 9c779efdcd7c440bebb727024073b6a02ea3197e (commit)
via a3157af700b3b46bdfd566fc87d54e7b917d1e49 (commit)
via 86d9559cb14b56f817ce98776b4f94ca98996f5c (commit)
via 6e5201e924fc74a6828064c54863a986f8ac825d (commit)
from 04f1f23bcd0e631ff98f6b7a3a27de0f47dee252 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 74fe7c3eaacf8fb42e1be8b9fd1accc9bb750c08
Author: Galen Charlton <gmc at esilibrary.com>
Date: Fri Jan 10 16:55:37 2014 +0000
Bug 10952: (follow-up) remove mention of KohaOpacRecentSearches cookie
Now that this cookie no longer exists, remove mention of it
from a test case.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
(cherry picked from commit da853bf74eefbd935734177722aaa763ce71d170)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 9c779efdcd7c440bebb727024073b6a02ea3197e
Author: Galen Charlton <gmc at esilibrary.com>
Date: Fri Jan 10 16:49:01 2014 +0000
Bug 10952: (follow-up) clear seach history from session after saving it to DB
This patch makes sure that the search history from an
anonymous session is cleared from the session after a user
logs in (and the session history is saved to that user's
record in the database). This fixes a problem where the
search history from the session got repeatedly added to the
database each time the user did something while logged
into the OPAC.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
(cherry picked from commit 914515202df0612c1cdb64bf408120a1364316a0)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit a3157af700b3b46bdfd566fc87d54e7b917d1e49
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Mon Jan 6 10:00:41 2014 +0100
Bug 10952: (follow-up) Always flush session after deletion
This is recommended in CGI::Session documentation.
Signed-off-by: Charlene Criton <charlene.criton at univ-lyon2.fr>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
(cherry picked from commit 939d68ea7b0fb7c0649531b324ad4938a5360c0e)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 86d9559cb14b56f817ce98776b4f94ca98996f5c
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Wed Dec 18 10:58:36 2013 +0100
Bug 10952: (follow-up) comments fixes and unit tests
- Remove unit tests for ParseSearchHistoryCookie, which doesn't exist
anymore
- Add unit tests for ParseSearchHistorySession and
SetSearchHistorySession
- Remove/Modify comments about search history cookie
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Tests fixed and moved, and comments tidied up
Signed-off-by: Charlene Criton <charlene.criton at univ-lyon2.fr>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
(cherry picked from commit bbf7cd6876e94865492e3fd19e59c31b6b95b588)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 6e5201e924fc74a6828064c54863a986f8ac825d
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Thu Sep 26 11:22:26 2013 +0200
Bug 10952: Store anonymous search history in session
Storing search history into cookie can cause problems, due to the size
limitation of 4KB.
The solution here is to store search history into the CGI::Session
object, so there is no size limitation (but anonymous search history
still remember up to 15 requests max.)
Test plan:
- Go to OPAC in anonymous mode.
- Check that the "Search history" link is *not* shown in the top right
corner of the page
- Make some searches on /cgi-bin/koha/opac-search.pl
- The "Search history" link should appear. Click.
- Your search history should be displayed.
- Try to log in with invalid username/password
- Go back to search history, it's still there
- Now log in with valid username/password
- Your anonymous search history should be saved into your own search
history.
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Restoring original sign offs and comments below
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Work as described. No koha-qa errors
Well, search history saving is similar before and after patch.
i.e. anonmymous search is saved when user logs in, but cookie
KohaOpacRecentSearches is empty.
Shows current an previous session searches
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
All tests and QA script pass, works as described.
Signed-off-by: Charlene Criton <charlene.criton at univ-lyon2.fr>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
(cherry picked from commit d07df7d51250bb5a40bb556aab48afb18a67a396)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Auth.pm | 69 ++++++++++++++------
.../prog/en/modules/opac-search-history.tt | 2 +-
opac/opac-search-history.pl | 22 +++----
opac/opac-search.pl | 18 ++---
t/db_dependent/Auth.t | 4 +-
t/db_dependent/Auth_ParseSearchHistoryCookie.t | 43 ------------
t/db_dependent/Auth_SearchHistorySession.t | 52 +++++++++++++++
7 files changed, 117 insertions(+), 93 deletions(-)
delete mode 100644 t/db_dependent/Auth_ParseSearchHistoryCookie.t
create mode 100644 t/db_dependent/Auth_SearchHistorySession.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list