[koha-commits] main Koha release repository branch master updated. v3.14.00-431-ge27ea08
Git repo owner
gitmaster at git.koha-community.org
Tue Feb 18 22:25:13 CET 2014
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via e27ea08887a0332692c37b05b15021b14b1bef78 (commit)
via 201af593f885ecb11c76d02baa6e27ef5e744e30 (commit)
via 2fac9a76450835337b015956a6f3150586aa5a17 (commit)
from d3c565f12c5c9136588a17e6497d860f6c5e95ed (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit e27ea08887a0332692c37b05b15021b14b1bef78
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Tue Feb 18 16:26:07 2014 +0100
Bug 10789: Follow-up: restored second SQL parameter in GetLastOrderReceivedFromSubscriptionid
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 201af593f885ecb11c76d02baa6e27ef5e744e30
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Tue Feb 18 16:04:46 2014 +0100
Bug 10789: Follow-up: Fix typo "infermation"
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 2fac9a76450835337b015956a6f3150586aa5a17
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date: Sun Dec 8 22:26:18 2013 +0000
Bug 10789: Remove unnecessary calls to $sth->finish in C4::Acquisitions
C4::Acquisitions contained a number of unnecessary calls to
$sth->finish. Removed these and the associated variables introduced to
cache query results between fetch and the return
Where finish was the end of the routine I have added an
explicit return to document that no data is returned.
A number of places made query calls and fetched a single
row. Such a case could require an explicit finish.
These assume that they are looking up with a unique key.
To remove assumptions and isolate the code from future changes
I've switched these to fetching all and returning the
first row. I have commented these cases.
For fuller explanation see perldoc DBI
What I tested:
Edit existing basket, chnged name
Modify order line, change vendor price
Create new basket and add order
Delet this order
Delte this basket
New Basket, new order, user added, user removed
Add contract to vendor, change details, delete contract
Search order biblio
Create basket group, add basket to group, remove basket from group
Delete basket group
Receive order
Everything behaved as I expected
Signed-off-by: Marc Veron <veron at veron.ch>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Acquisition.pm | 139 ++++++++++++++++++++++-------------------------------
1 file changed, 58 insertions(+), 81 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list