[koha-commits] main Koha release repository branch master updated. v3.14.00-470-gd95ad08
Git repo owner
gitmaster at git.koha-community.org
Thu Feb 20 17:45:54 CET 2014
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via d95ad086a35a7927bb7bc02453a1a1341387dc6a (commit)
via 5dc093b30e8d949f39a67bf2ac40f219f6167d0a (commit)
via 1d9b86aabccf1bc916b6b27e568ad984caf081f6 (commit)
via 19bf1e9a40ab5a8f3c86fb07dd6429bfc44f703b (commit)
via 4e9b5110d90c3ac60c61f710ff5892b9720e643e (commit)
via 03675fd55320f3a9bc3d4c7475bc3b9696920bd9 (commit)
via 7faff33c8b9bd670cf7813f4cefb7aee38709ebb (commit)
from 6a323ce4ce914e757d5c1c999237ad2c0efc15e9 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit d95ad086a35a7927bb7bc02453a1a1341387dc6a
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Feb 19 11:36:30 2014 -0500
Bug 11791 - Use validation plugin when creating new city
The page for adding a new city includes some custom form
validation JavaScript which can be removed in favor of HTML5 validation
attributes and Koha's built-in validation plugin. This patch does so.
To test, apply the patch and go to Administration -> Cities -> New city.
Try submitting the form without entering a city or zip code. This should
trigger a validation warning.
Submission of the form with valid data should work correctly. Editing an
existing city should also work correctly.
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Note: This patch changes the behavior. Before the patch, only 1 out of city
and zip was required. Now both are. Since the 2 inputs were marked as
required, I think they should be.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 5dc093b30e8d949f39a67bf2ac40f219f6167d0a
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Feb 19 11:59:33 2014 -0500
Bug 11792 - Use validation plugin when creating new currency
The page for adding a new currency includes some custom form
validation JavaScript which can be removed in favor of HTML5 validation
attributes and Koha's built-in validation plugin. This patch does so.
To test, apply the patch and go to Administration -> Currencies &
Exchange rates -> New currency. Try submitting the form without entering
a currency, rate, and/or symbol. This should trigger a validation warning.
Submission of the form with valid data should work correctly. Editing an
existing currency should also work correctly.
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 1d9b86aabccf1bc916b6b27e568ad984caf081f6
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Feb 19 12:29:34 2014 -0500
Bug 11793 - Use validation plugin when creating new item type
The page for adding a new item type includes some custom form
validation JavaScript which can be removed in favor of HTML5 validation
attributes and Koha's built-in validation plugin. This patch does so.
To test, apply the patch and go to Administration -> Item types -> New
item type. Try submitting the form with the following error conditions:
- Missing item type
- Missing description
- A non-number in the "rental charge" field
These errors should trigger a validation warning.
Submission of the form with valid data should work correctly. Editing an
existing item type should also work correctly.
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 19bf1e9a40ab5a8f3c86fb07dd6429bfc44f703b
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Feb 19 13:05:19 2014 -0500
Bug 11795 - Use validation plugin when creating new Z39.50 server
The page for adding a new Z39.50 server includes some custom form
validation JavaScript which can be removed in favor of HTML5 validation
attributes and Koha's built-in validation plugin. This patch does so.
To test, apply the patch and go to Administration -> Z39.50 client
targets -> New Z39.50 server. Try submitting the form with any of the
following error conditions:
- Missing Z39.50 server name
- Missing hostname
- Missing port
- Non-numeric port
- Missing database
- Non-numeric rank
- Non-numeric timeout
These errors should trigger a validation warning.
Submission of the form with valid data should work correctly. Editing
an existing Z39.50 server should also work correctly.
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Amended patch: replace tabs with spaces
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 4e9b5110d90c3ac60c61f710ff5892b9720e643e
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Feb 18 15:26:30 2014 -0500
Bug 11788 - Use validation plugin when creating new course
The page for adding a new course includes some custom form
validation JavaScript which can be removed in favor of HTML5 validation
attributes and Koha's built-in validation plugin. This patch does so.
To test, apply the patch and go to Course reserves -> New course. Try
submitting the form without entering a department, course number,
and/or course name. This should trigger validation warnings.
Submission of the form with valid data should work correctly. Editing an
existing course should also work correctly.
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 03675fd55320f3a9bc3d4c7475bc3b9696920bd9
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Feb 18 14:52:26 2014 -0500
Bug 11787 - Use validation plugin when adding new vendor
The vendor entry form uses some custom JavaScript which can be removed
in favor of HTML5 validation attributes and Koha's built-in validation
plugin. This patch does so.
Also corrected: Minor validation issue.
To test, apply the patch and go to Acquisitions -> New vendor. Try
submitting the form without entering a vendor name. This should trigger
a validation warning.
Submission of the form with valid data should work correctly. Editing an
existing vendor should also work correctly.
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 7faff33c8b9bd670cf7813f4cefb7aee38709ebb
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Feb 18 12:13:39 2014 -0500
Bug 11785 - Use validation plugin when uploading local cover images
When uploading local cover images the form should not be submitted if
no file has been selected. The existing form validation script doesn't
work. This patch adds HTML5 validation attributes and use of Koha's
built-in form validation plugin.
To test, apply the patch and go to Tools -> Upload local cover image.
Try to submit the form without selecting a file to upload. You should be
prevented from doing so. Choose a file and confirm that the upload
completes correctly.
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
-----------------------------------------------------------------------
Summary of changes:
.../prog/en/modules/acqui/supplier.tt | 21 ++----
.../intranet-tmpl/prog/en/modules/admin/cities.tt | 19 ++---
.../prog/en/modules/admin/currency.tt | 37 +++-------
.../prog/en/modules/admin/itemtypes.tt | 60 +++-------------
.../prog/en/modules/admin/z3950servers.tt | 74 +++++++-------------
.../prog/en/modules/course_reserves/course.tt | 45 +++---------
.../prog/en/modules/tools/upload-images.tt | 21 +++---
7 files changed, 74 insertions(+), 203 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list