[koha-commits] main Koha release repository branch master updated. v3.14.00-494-g521d717

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  521d7173720b4acbf4ecf40ed114520d500c5f6a (commit)
      from  59b9078a3f7cf240bd814ee611e8f553d043491e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 521d7173720b4acbf4ecf40ed114520d500c5f6a
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Fri Feb 7 10:13:39 2014 +0100

    Bug 11707: fix editing additional attributes for patron whose category code includes a space
    
    When editing additional attributes of a patron of a category with a
    code with space (ie "CAT 3"), the Javascript is broken and Additional
    attributes are not displayed.
    
    This patch corrects by adding simple quotes around category code in JS
    code.
    
    Test plan :
    - Create an patron additional attribute
    - Create a new patron category with a space in code. ie "CAT 3"
    - Create a new patron of this category : /cgi-bin/koha/members/memberentry.pl?op=add&categorycode=CAT 3
    => Without patch the JS is broken (Syntax error, unrecognized expression:
       [data-category_code=CAT 3]) and additional attributes are not
       displayed.
    => With patch the JS is not broken and additional attributes are
       displayed and can be edited.
    
    Signed-off-by: Marc Véron <veron at veron.ch>
    
    In current Koha version it is not possible to create category codes
    with blanks.
    
    To test, I changed an existing category code directly in the database.
    Then I followed the Test plan.
    Without patch, attribute types were not displayed.
    With patch, they were displayed as expected.
    
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    I recommend not using codes with spaces and fix existing ones.
    Koha doesn't allow you to add category codes with spaces, so the only way
    to do it is via SQL.
    This patch fixes a problem and passes all tests.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


hooks/post-receive
-- 
main Koha release repository