[koha-commits] main Koha release repository branch master updated. v3.14.00-236-gb529ca0

Mon Jan 6 06:30:56 CET 2014

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  b529ca00e0cac093fc32a1d123cdbcc84582c155 (commit)
       via  81a302360aea10bca1598b32b711c48216e486ac (commit)
       via  690fbfbb8aa97729f8eeb810e3ec91adbc15be50 (commit)
       via  e45edca42a44d094eabbd3347cc83b43cd2166f4 (commit)
       via  bb750253644e0ba6ea04e36c80088626e8163bf2 (commit)
       via  7c518bd250cd2283a055d4547085cd6db6488cf7 (commit)
      from  543e1dc6731d4a26b777223920bfe4037e7546dd (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit b529ca00e0cac093fc32a1d123cdbcc84582c155
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Thu Jan 2 14:42:16 2014 +0000

    Bug 11468: Remove given/when from Koha::Dateutils

    given and when give warnings due to their experimental
    status as of perl 5.18. Replace the construct with
    an if/elsif to avoid the keywords

    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Passes all tests and QA script, especially t/DateUtils.t.

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 81a302360aea10bca1598b32b711c48216e486ac
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Mon Jan 6 05:46:32 2014 +0000

    Bug 11474: (follow-up) correct typos in POD

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 690fbfbb8aa97729f8eeb810e3ec91adbc15be50
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Fri Jan 3 10:47:23 2014 +0000

    Bug 11474: Remove errors caused by use of given/when statement

    This patch replaces a given/when statement by an if so we
    do not get warnings on compilation when using Perl 5.18 or later.

    Note the perldoc for the subroutine was not correct;
    code was not testing that paramater equalled the values
    but that it contained them. Have amended accordingly

    Have documented behaviour in case parameter contains
    neither value.

    Subroutine does not appear to me used elsewhere in
    codebase

    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Passes all tests and QA script, especially t/DateUtils.t.

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit e45edca42a44d094eabbd3347cc83b43cd2166f4
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Wed Nov 27 13:16:56 2013 -0500

    Bug 11316 - plugin icon missing tooltip in addbiblio.pl

    By adding:
        title=\"Tag editor\"
    into the HTML generated in addbiblio, a tooltip displaying
    'Tag editor' appears when the mouse is hovered over the
    plugin icon.

    Test Plan:
    1) Log into Staff client
    2) Click the 'Search the catalog' tab
    3) Type something which will generate results
    4) Click the title of a result
    5) Click the 'Edit' button
    6) Scroll down and click the 'Edit Record'
    7) Look through the various tabs and notice that all the plugin
       icons have no tooltip.
    8) Apply the patch
    9) Refresh the page
    10) All the plugin icons should have the tooltip text of
        'Tag editor'.

    Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Adds a title attribute. Works as described.

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit bb750253644e0ba6ea04e36c80088626e8163bf2
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Mon Dec 30 16:05:51 2013 +0000

    Bug 7002: fix some invalid superlibrarian permission checks

    This patch fixes a problem where if a staff user has superlibrarian
    permissions, but also has module-specific permissions, they are
    prevent from editing item records that they should be allowed to.

    To test:

    [1] Turn on IndependentBranches.
    [2] Register a superlibrarian staff user at branch A.
    [3] Give that new account at least one other module-level
        permission.  This cannot be done through the user interface,
        however, but can be done via SQL:

        UPDATE borrowers SET flags = 3 WHERE userid = 'XXX';

    [4] Log in as that new superlibrarian.
    [5] Bring up the item details (catalogue/moredetail.pl) page for
        an item at branch B.  Note that there is no 'Edit Item' link.
    [6] Similarly, try editing that item (cataloging/additem.pl).  Note
        that the edit form forbids you from touching the item.
    [7] Finally, try editing that item using the Tools | Batch item
        modification utility.  Note that it doesn't allow you to do so.
    [8] Apply the patch.
    [9] Repeat steps 5 through 7.  This time, the item actions should
        be allowed.

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Works as described, passes QA script and test suite.

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 7c518bd250cd2283a055d4547085cd6db6488cf7
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Thu Jan 2 18:02:17 2014 +0000

    Bug 11470: fix occassional spurious test failure in Circulation_transfers.t

    This patch makes Circulation_transfers.t no longer be sensitive to
    the exact time it runs, avoiding spurious test failures due
    to datesent being a second off between the creation of the test
    transfer and the comparison.

    To test:

    [1] To simulate the failure, add a "sleep(2);" after the
        "#Test GetTransfers" comment and run
        prove -v t/db_dependent/Circulation_transfers.t
    [2] Remove the sleep and apply the patch.
    [3] Verify that prove -v t/db_dependent/Circulation_transfers.t passes.

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Works as described.

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Utils/DataTables.pm                 |   18 ++++++-------
 Koha/DateUtils.pm                      |   43 +++++++++++++++-----------------
 catalogue/moredetail.pl                |    2 +-
 cataloguing/addbiblio.pl               |    4 +--
 cataloguing/additem.pl                 |    2 +-
 t/db_dependent/Circulation_transfers.t |   14 +++++------
 tools/batchMod.pl                      |    2 +-
 7 files changed, 40 insertions(+), 45 deletions(-)

hooks/post-receive
-- 
main Koha release repository