[koha-commits] main Koha release repository branch master updated. v3.14.00-283-ge96d73a

Git repo owner gitmaster at git.koha-community.org
Tue Jan 14 17:15:20 CET 2014


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  e96d73aa9f462fb653b8b67d7d5bff81dab94be7 (commit)
       via  5ebca4f3409e1341be25ab7c11af4de736c11ff2 (commit)
       via  5c3f36279b93e13be4773c7b88df39c99f8b2aca (commit)
      from  8fbf21da1c540d19cc19fe75c0a5cb83a8fbe849 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit e96d73aa9f462fb653b8b67d7d5bff81dab94be7
Author: David Cook <dcook at prosentient.com.au>
Date:   Thu Jan 9 17:12:26 2014 +1100

    Bug 11502: make library filter in "Holds To Pull" more precise
    
    This patch uses regex checking via the DataTables fnFilter API method
    to make the branch filter more precise on the "Holds to Pull" page.
    
    The ability to use regex is built into DataTables so this just adds
    the actual expression.
    
    _TEST PLAN_
    
    Before applying:
    
    1) Add library (branches) with codes of NM, NMH, and NB
    2) Add items (that can be placed on hold) at all these branches
    3) Place a hold on an item that is only available at NM
    4) Place a hold on an item that is only available at NMH
    5) Place a hold on an item that is only available at NM and NB
    6) Go to "Holds to Pull" in the Circulation module
    7) Filter by these three different values
    8) Note that filtering by "NM" will incorrectly bring up all three
    holds, while "NMH" and "NB" will only pull up one (like they should).
    
    Apply the patch.
    
    9) Shift+refresh the page so that your Javascript refreshes
    10) Repeat step 7 (filtering by the different branch values)
    11) Note that filtering by "NM" will now only bring up the hold for "NM"
    and the hold for "NM" and "NB", while the others still only bring up
    one hold.
    
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 5ebca4f3409e1341be25ab7c11af4de736c11ff2
Author: alex_h <dhorsman at xtra.co.nz>
Date:   Tue Jan 14 11:52:04 2014 +1300

    Bug 11537: Increasing test coverage for C4::Log
    
    To test:
    1. run prove t/Log.t
       Notice 1 test is run
    2. apply patch
    3. run prove t/Log.t
       Notice 3 tests are run
    
    Signed-off-by: David Cook <dcook at prosentient.com.au>
    
    Works as described.
    
    I think there might be a typo in "Testing git log status". Should
    this read "Testing get log status"? (Noticed while looking at the
    code/running perl t/Log.t.)
    
    In any case, thanks for the patch. Looks good!
    
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    
    Fixed typo, thanks David
    
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Works as described:
    1..3
    ok 1 - use C4::Log;
    ok 2 - Testing GetLogStatus
    ok 3 - Testing hash is non empty
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 5c3f36279b93e13be4773c7b88df39c99f8b2aca
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Mon Jan 13 21:51:56 2014 +0000

    Bug 11535: sanitize input from patron self-registration form
    
    This patch adds the use of C4::Scrubber to the processing of input
    from the patron self-registration form, thereby closing off one
    avenue for Javascript injection.
    
    To test:
    
    [1] Use the OPAC self-registration form to enter a new patron,
        and set its address to something like:
    
        <span style="color: red;">BAD</span>
    
    [2] In the staff interface, bring up the new patron record.  The
        address will show up in red, indicating a successful HTML
        injection.
    [3] Apply the patch and use self-registration to enter a new
        patron with a similar case of unwanted HTML coding.
    [4] Bring up the second patron in the staff interface.  This time,
        the undesirable HTML tag should not be present.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Liz Rea <liz at catalyst.net.nz>
    Tags are not present on testing.
    
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Confirmed bug and that the patch fixes it.
    Passes all tests and QA script.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt |    6 +++++-
 opac/opac-memberentry.pl                                        |    4 +++-
 t/Log.t                                                         |    5 ++++-
 3 files changed, 12 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list