[koha-commits] main Koha release repository branch 3.14.x updated. v3.14.01-98-gbd566f8

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.14.x has been updated
       via  bd566f8c0a053b845208345dbd2a076764b475ad (commit)
       via  bbc101bb1cb6705ea518b5f4fbd786393c643c22 (commit)
       via  828d9b9f20fa4f01b6fb6bd4d9ff20d674f3ceac (commit)
       via  a3f0eb97697213a267de0f8191e2acbc4197f6ab (commit)
      from  0c4e9a01544d898db10e704aea15633d689311be (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit bd566f8c0a053b845208345dbd2a076764b475ad
Author: Fridolin SOMERS <fridolin.somers at biblibre.com>
Date:   Thu Jan 16 17:55:10 2014 +0100

    Bug 8018: DBRev 3.14.00.005
    
    Signed-off-by: Fridolin SOMERS <fridolin.somers at biblibre.com>

commit bbc101bb1cb6705ea518b5f4fbd786393c643c22
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date:   Mon Dec 23 19:49:14 2013 +0100

    Bug 8018: (follow-up) fixing some wrong capitalization
    
    Fixes capitalization in 2 places:
    
    - Delete a subfield - Yes/No options
    - Edit a subfield - Edit subfield
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 3b9d8074b85b7d06c555491a75a48ac751560ec2)
    Signed-off-by: Fridolin SOMERS <fridolin.somers at biblibre.com>

commit 828d9b9f20fa4f01b6fb6bd4d9ff20d674f3ceac
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Thu Dec 12 12:24:11 2013 -0300

    Bug 8018: (followup) make the default more explicit
    
    This patch:
    - Makes the new subfield tab show maxlength=9999 as default (instead of
      empty-then-zero).
    - Updates the help to make exlpicit that 0 or empty defaults to 9999.
    - Assumes all the subfields created with maxlength=0 inadvertedly are
      meant to mean "no limit" and hence update the database to reflect
      that.
    
    To test (this patch and Pablo's):
    - Edit a MARC framework, edit some field's subfields.
    - Use the 'New' tab to create a new subfield (choose an unused letter).
    - See in "More constrains" that the "Max length" field is empty. Leave
      it as-is.
    - Save the changes (the new subfield).
    - Edit the field again, verify that "Max length" is 0.
    - Try tu use the framework and the the field/subfield just created
      > FAIL
    - Apply the patches, upgrade
    - Try to use the framework/field/subfield > SUCCESS (0 was converted to
      9999)
    - Repeat from the begining, "Max length" should show 9999 on the new
      subfield tab.
    - Leave it empty, it is saved as 9999.
    
    Edit: small typo
    
    Sponsored-by: Universidad Nacionald de Cordoba
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Passes QA script and tests in t and xt.
    Tested:
    - deleting an existing subfield
    - adding a new subfield with new default 9999
    - editing the new subfield, changing value to 8888
    - deleting new subfield
    - adding new subfield, using 8888 as length
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit b5eab7c20bb8c2d07966bf1f68eaf0a7f953222e)
    Signed-off-by: Fridolin SOMERS <fridolin.somers at biblibre.com>
    
    Conflicts:
    	installer/data/mysql/updatedatabase.pl

commit a3f0eb97697213a267de0f8191e2acbc4197f6ab
Author: Pablo Bianchi <pablo.bianchi at gmail.com>
Date:   Wed Dec 11 15:54:54 2013 -0300

    Bug 8018: MARC framework max subfield length should default to 9999
    
    The default value for the marc_subfield_structure.maxlenght is 9999
    in the DB. Currently the template passes an empty value which is casted to
    0 by the CGI.
    
    This simple patch validates the input and converts to the default (9999)
    if not defined or 0.
    
    Another approach could be changing the 9999 default and/or treating 0 as
    'no-limit'.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    Works by defaulting 0 or "" to 9999.
    
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 1ebbf40ecc07b9474e81e20ec1598659ab027d7a)
    Signed-off-by: Fridolin SOMERS <fridolin.somers at biblibre.com>

-----------------------------------------------------------------------

Summary of changes:
 admin/marc_subfields_structure.pl                              |    3 ++-
 installer/data/mysql/updatedatabase.pl                         |    8 ++++++++
 .../prog/en/modules/admin/marc_subfields_structure.tt          |    6 +++---
 .../prog/en/modules/help/admin/marc_subfields_structure.tt     |    2 +-
 kohaversion.pl                                                 |    2 +-
 5 files changed, 15 insertions(+), 6 deletions(-)


hooks/post-receive
-- 
main Koha release repository