[koha-commits] main Koha release repository branch master updated. v3.14.00-324-g0e0d524

Git repo owner gitmaster at git.koha-community.org
Fri Jan 17 06:47:26 CET 2014


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  0e0d524aeed7e82031ecf2339d42d67c2905b813 (commit)
       via  7e7b4c71be1d3a4b2339cda9ef3bbb7618a8964c (commit)
       via  490e38069c0b9fcf71449d7812a0056b68318c64 (commit)
       via  5885077fbbc97add0d077898c06726ef3106eee9 (commit)
       via  8b386419c07413c810c56482cd4b505cdb5f43f2 (commit)
       via  5b3535899acfdcd309d722dba39a8bdcdbdc54e4 (commit)
       via  ac6fb12c9aff29a652ee10c960ab10309d22adee (commit)
      from  a8aa6e8f7efd1ea29fdbd99cf3e573e72b424eb5 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 0e0d524aeed7e82031ecf2339d42d67c2905b813
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Fri Jan 17 05:54:09 2014 +0000

    Bug 11477: (follow-up) improve display of user/patrons in logs tool
    
    This patch tweaks the display of patron and user names in the logs
    tool so that if a name is present, the patron/user ID that follows
    it is enclosed in parentheses.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 7e7b4c71be1d3a4b2339cda9ef3bbb7618a8964c
Author: David Cook <dcook at prosentient.com.au>
Date:   Mon Jan 6 15:19:21 2014 +1100

    Bug 11477 - Add names for librarian and borrowers in the logs
    
    This patch adds the first name and surname of the librarian and the
    user involved in a transaction log, if available.
    
    If neither the firstname or the surname is available, then the 'object'
    number will be prefaced with the 'Member' qualifier.
    
    _TEST PLAN_
    
    0) This patch depends on Bug 11473, so you must apply it first
    
    Before applying this patch (11477):
    1) View the logs.
    2) Note that the Librarian column just has a number
    3) Note that the Object column will just say Member X (where X is a
    number), in the circulation, fines, and patron/member modules.
    
    Apply the patch.
    
    4) Reload the logs (you don't need to make new ones)
    5) Note that the Librarian and Object columns mentioned above now
    have firstname and surname appearing (where available)
    
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Works as described, passes all tests and QA script.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 490e38069c0b9fcf71449d7812a0056b68318c64
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Fri Jan 17 06:04:37 2014 +0000

    Bug 11473: (follow-up) ensure link to item is construct correctly
    
    This patch adjusts the check on action_logs.info to better detect
    if the event concerns an item.  This fixes a problem where the links
    from log entries on item modifications would, if followed, result
    in internal server errors.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 5885077fbbc97add0d077898c06726ef3106eee9
Author: David Cook <dcook at prosentient.com.au>
Date:   Mon Jan 6 15:01:10 2014 +1100

    Bug 11473 - add 'biblio' and 'item' to cataloguing logging info
    
    This patch adds the words 'biblio' and 'item' to the 'info'
    of the cataloguing logs which were missing them (such as biblio
    delete, biblio mod, item mod, upload cover image).
    
    This patch also adds 'authority' for authority mod.
    
    _TEST PLAN_
    
    Before applying:
    1) Create/view mods for items, biblios, and authorities.
    2) Create/view biblio deletion
    3) Create/view upload cover image log
    4) Note that none of these contain the words 'biblio','item',or
    'authority' in their "Info" columns.
    
    Apply patch.
    
    5) Repeat steps 1-3
    6) Note that the new logs contain 'biblio','item', and 'authority'
    in their "Info" column, while the past ones don't.
    7) Note also that 'biblio' and 'item' will have 'Biblio' and 'Item'
    appear in their "Object" column for the new logs
    
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 8b386419c07413c810c56482cd4b505cdb5f43f2
Author: David Cook <dcook at prosentient.com.au>
Date:   Mon Jan 6 14:49:01 2014 +1100

    Bug 11473 - Improve wording in log viewer template
    
    This patch capitalizes 'member' and 'biblio' as object labels in the
    log viewer.
    
    It also adds a "Subscription" label, and changes "auth" to "Authority".
    
    _TEST PLAN_
    
    Before applying patch:
    
    1) View logs for patrons, new biblio, serials, and authorities.
    
    Apply the patch:
    
    1) Notice the capitalization and new/modified labels.
    
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 5b3535899acfdcd309d722dba39a8bdcdbdc54e4
Author: David Cook <dcook at prosentient.com.au>
Date:   Mon Jan 6 14:43:53 2014 +1100

    Bug 11473 - Remove boilerplate in log viewer template
    
    This patch eliminates unnecessary conditions and boilerplate.
    
    _TEST PLAN_
    
    Apply the patch.
    
    1) Try viewing logs for circulation, patrons, fines,
    cataloguines, serials, authorities, etc.
    2) Note that everything should look exactly the same as before,
    with one exception: FINES
    3) Fines will now show "member X" for the user associated with
    the fine.
    
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit ac6fb12c9aff29a652ee10c960ab10309d22adee
Author: David Cook <dcook at prosentient.com.au>
Date:   Mon Jan 6 14:32:31 2014 +1100

    Bug 11473 - Fix log viewer template conditions
    
    This patch adds the 'loopro' key to the 'module' value, so that
    conditions are actually triggered in the template logic.
    
    (Note: loopro.CIRCULATION is valid, but I changed it for the sake
    of consistency across the different conditions.)
    
    This patch also adds substr checks to the 'info' column when
    using the cataloguing module. This will check for 'item' and 'biblio',
    so that the appropriate label qualifer can be shown in the log viewer.
    If either term is absent, the unqualified number will be shown instead
    (this will be the majority of action logs at this point).
    
    _TEST PLAN_
    
    Before applying:
    
    1) Access log viewer from Tools (or wherever really)
    2) Look up logs for circulation, patrons, cataloguing, serial,
    authorities, etc.
    3) Note that the "Object" will always just be a number without qualification.
    
    After applying the patch:
    
    1) Look at those same logs
    2) Note that the object number for borrowers will usually be prefaced
    by 'member' (notwithstanding FINES which aren't taken into account in
    this template yet); new bibs and new items should say 'Item X' or
    'Biblio X'. Serials should have a link. Authorities should have a link
    and an 'auth' preface.
    
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    
    Works as advertised
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/AuthoritiesMarc.pm                              |    2 +-
 C4/Biblio.pm                                       |    4 +--
 C4/Items.pm                                        |    2 +-
 .../intranet-tmpl/prog/en/modules/tools/viewlog.tt |   36 +++++++-------------
 tools/upload-cover-image.pl                        |    2 +-
 tools/viewlog.pl                                   |   24 ++++++++++++-
 6 files changed, 41 insertions(+), 29 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list