[koha-commits] main Koha release repository branch master updated. v3.14.00-336-gfc698ee

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  fc698eed06ec9a7335c4b94362917d2b364b44c4 (commit)
      from  59c0a0e02b9b4dd179c99c31ebbd13e70f266d77 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit fc698eed06ec9a7335c4b94362917d2b364b44c4
Author: Fridolyn SOMERS <fridolyn.somers at biblibre.com>
Date:   Wed Nov 27 16:40:09 2013 +0100

    Bug 11313: supply empty value in mandatory comboboxs in MARC record editors
    
    In biblio (or authority) record editing or creation, Bug 3727 added
    an empty value to combobox for subfields using itemtype authorized values,
    which is mandatory and does not have a default value. This to avoid
    selecting arbitrarily the first value of the combobox.
    
    This patch extends this behavior to normal authorized values like CCODE,
    COUNTRY ...
    
    Also, when record already exists and has a defined value for the subfield
    this value will be selected in combobox so there is no need for an empty
    value.
    
    Test plan :
    - In a biblio framework, set a subfield mandatory and using itemtypes
      authorised values
    - Set a default value for this subfield
    - Create a new record with the framework
    => You see the subfield with a combobox, the first empty value is selected
    - Go to biblio framework and set a default value for the subfield
    - Create a new record with the framework
    => You see the subfield with a combobox, the default value is selected
       and there is no empty value
    - Select an other value and save the record
    - Edit this record
    => You see the subfield with a combobox, the saved value is selected and
       there is no empty value
    
    Perform same tests with a normal authorized values categorie (instead of
      itemtypes).
    Perform same tests with with authority creation/edition
    Perform same tests with a normal authorized values categorie and authority
      creation/edition
    
    Signed-off-by: David Cook <dcook at prosentient.com.au>
    
    Works as described.
    
    Fridolyn: I had a lot of difficulty understanding your test plan,
    especially since the second line should not be in the test plan
    (since if there is a default value, no empty value should appear).
    
    Perhaps it would be useful to use more whitespace to separate
    steps and the things for which a tester should check.
    
    Also, it might be useful to specify what testers should check for
    before and after applying the patch, so that they're sure that the
    behaviour has been corrected.
    
    In any case, the patch works! Certainly a helpful addition.
    
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Passes all tests and QA script.
    
    1) Adding a bibliographic record
    Subfield is mandatory, no default value:
    - adding record: no value is preselected, empty value exists
    - editing record: saved value is shown,  empty value exists
    Subfield is mandatory, defined default value:
    - adding record: default is preselected, no empty value
    - editing record: saved value is shown, no empty value exists
    Subfield is not mandatory, defined default value:
    - adding record: default is preselected, empty value exists
    - editing record: saved value is shown, emtpy value exists
    Subfield is not mandatory, no default value:
    - adding record: empty value is preselected
    - editing record: saved value is shown, empty value exists
    
    2) Adding an authority record
    Repeating tests from above.
    - Subfield is mandatory, no default value: OK
    - Subfield is mandatory, defined default value: OK
    - Subfield is not mandatory, defined default value: OK
    - Subfield is not mandatory, no default value: OK
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 authorities/authorities.pl |    6 ++++--
 cataloguing/addbiblio.pl   |    6 ++++--
 2 files changed, 8 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
main Koha release repository