[koha-commits] main Koha release repository branch master updated. v3.14.00-361-g1cc0d7b

Git repo owner gitmaster at git.koha-community.org
Thu Jan 23 19:15:23 CET 2014


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  1cc0d7b700f27ac3bacb2964475da1f3aabbc919 (commit)
       via  f474c9dea10828e80dbed909e6c70904158535b6 (commit)
       via  1410c32dabac5f5b513c60122745eb20cf7a6881 (commit)
      from  443ec407861762b8249685700e9cf18c9a9407e2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 1cc0d7b700f27ac3bacb2964475da1f3aabbc919
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Thu Jan 23 18:32:06 2014 +0000

    Bug 10907: (follow-up) fix table sorting
    
    This patch fixes a problem wherein table sorting did not work if
    OpacSuggestionManagedBy was off.
    
    As a matter of style, this patch also modifies the (Boolean) syspref
    check to be just:
    
    [% IF Koha.Preference( 'OpacSuggestionManagedBy' ) %]
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit f474c9dea10828e80dbed909e6c70904158535b6
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Thu Jan 23 18:24:00 2014 +0000

    Bug 10907: DBRev 3.15.00.015
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 1410c32dabac5f5b513c60122745eb20cf7a6881
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date:   Mon Dec 9 18:40:33 2013 +0100

    Bug 10907: Optionally show the staff member's name who managed a suggestion in OPAC
    
    The name of a staff member who managed a suggestion is shown in the
    the OPAC if the new system preference OpacSuggestionManagedBy is set to
    'Show'. This is also the default.
    
    If the preference is set to 'Don't show' the staff members name
    is not displayed and the column 'Managed by' in the table of
    suggestions in the patron account is not displayed.
    
    To test:
    - Create a one or more suggestions
    - 'Manage' them by accecpting or rejecting
    - Go to your patron account and check that the staff member name is
      shown for your suggestions
    - Apply patch, run database update
    - Check the name is still shown
    - Switch the preference to 'Don't show'
    - Check the name is no longer shown and the table still displays
      correctly, but without the 'Managed by' column
    - Repeat those tests for both bootstrap and prog theme!
    
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    
    Works as advertised, the only little nitpick is you could just do
    [% IF Koha.Preference( 'OpacSuggestionManagedBy' ) %]
    
    However you are following the custom in that file already, so that's
    fine
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-----------------------------------------------------------------------

Summary of changes:
 installer/data/mysql/sysprefs.sql                               |    1 +
 installer/data/mysql/updatedatabase.pl                          |    7 +++++++
 .../intranet-tmpl/prog/en/modules/admin/preferences/opac.pref   |    6 ++++++
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt    |    6 ++++--
 koha-tmpl/opac-tmpl/prog/en/modules/opac-suggestions.tt         |    6 ++++--
 kohaversion.pl                                                  |    2 +-
 6 files changed, 23 insertions(+), 5 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list