[koha-commits] main Koha release repository branch 3.14.x updated. v3.14.02-5-gf1bb461

Git repo owner gitmaster at git.koha-community.org
Mon Jan 27 13:15:16 CET 2014


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.14.x has been updated
       via  f1bb46172bdc90db00a08c2c78e169952fd22feb (commit)
       via  895f989dcaad44830bc85d855d71b654170dbb1d (commit)
      from  b0c11d03aadcb16fef00a10011080aadc3a38de1 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit f1bb46172bdc90db00a08c2c78e169952fd22feb
Author: Fridolyn SOMERS <fridolyn.somers at biblibre.com>
Date:   Thu Mar 7 16:02:55 2013 +0100

    Bug 7518: certain searches with quotation marks don't work
    
    Under certain circumstance, a search term without quotation marks
    returns the expected results while the same search with a
    double quote embedded in it would fail.
    
    Koha should ignore the quotation marks and return results anyway.
    
    This appears when  QueryWeightFields syspref is activated (and
    QueryAutoTruncate is off), as field weighting builds a complex CCL
    query using double quotes around search words.  This patch simply
    replaces double quotes in search words by a space.
    
    Test plan :
    - Set QueryAutoTruncate off (you may also need to set QueryFuzzy to off)
    - Set QueryWeightFields off
    - Perform a serch on two words where you have results, like : centre "ville
    => you get results
    - Set QueryWeightFields on
    - Perform same serch
    => you get the same results
    
    Signed-off-by: Leila <koha.aixmarseille at gmail.com>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 868855df4b674b495966c022392068c2fdd3a35f)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 895f989dcaad44830bc85d855d71b654170dbb1d
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Tue Dec 17 16:32:09 2013 +0000

    Bug 7518: regression test double-quote in search operand
    
    Under certain circumstances, namely where QueryParser is off,
    QueryWeightFields is on, and QueryFuzzy and QueryAutoTruncate are
    off, a search with a double-quote embedded in it can fail: for
    example
    
        web application
    
    would return results where
    
        web "application
    
    does not.
    
    This patch adds an automated regression test.
    
    To test:
    
    [1] Apply this patch and run prove -v t/db_dependent/Search.t;
        two tests should fail.
    [2] After applying the main patch that fixes the bug, the
        prove -v  t/db_dependent/Search.t should succeed.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 437f06624759c464d667107d9f73ec05283f6892)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Search.pm            |    1 +
 t/db_dependent/Search.t |   16 +++++++++++++++-
 2 files changed, 16 insertions(+), 1 deletion(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list