[koha-commits] main Koha release repository branch 3.14.x updated. v3.14.02-17-g9c4dd15

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.14.x has been updated
       via  9c4dd152956022c2ec391550c39aa9e97a87d58f (commit)
       via  4dbe5453a29b7d14f7ee45294f8172f75c245fd0 (commit)
      from  651d2120797a51a99c7cfa16b3a60f60da3829c1 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 9c4dd152956022c2ec391550c39aa9e97a87d58f
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Wed Dec 25 17:44:19 2013 +0000

    Bug 11445: avoid sending duplicate hold waiting notifications
    
    This patch fixes a problem where a patron could receive duplicate
    hold waiting notifications.  For example, this could happen if a
    circ operator checked in an item more than once and confirmed the
    same hold each time.
    
    To test:
    
    [1] Set up a test patron that received hold waiting notifications.
    [2] Put an item on hold for the patron, then check the item in
        and confirm the hold.  Verify that a hold notification is
        sent (or inspect the message_queue table).
    [3] Check the item in again and confirm the hold again.  A duplicate
        hold notification will be generated.
    [4] Apply the patch.
    [5] Repeat steps 2 and 3.  This time, only one notification should be
        generated.
    [6] Verify that prove -v t/db_dependent/Reserves.t passes.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Passes all tests and QA script.
    Works as described.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit fe08a0ef97ad2fbab72b857d61bec364fd93d9e9)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 4dbe5453a29b7d14f7ee45294f8172f75c245fd0
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Wed Dec 25 17:38:39 2013 +0000

    Bug 11445: regression test for duplicate hold notifications
    
    This patch implements a regression test for verifying that
    duplicate hold notifications aren't sent if ModReserveAffect() is
    called repeatedly (as might happen if a circ operator accidentally
    checks in an item and confirms its hold more than once).
    
    Note that the test depends on the fact that _koha_notify_reserve()
    defaults to sending a HOLD_PRINT letter if the borrower has not
    specified an email or SMS hold notification.
    
    To test:
    
    [1] Run prove -v t/db_dependent/Reserves.t
    [2] The 'patron not notified a second time (bug 11445)' test
        should fail.
    [3] Apply the main patch and run prove -v t/db_dependent/Reserves.t
        again.  This time all tests should pass.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 2b6a20c509801b9eeb562aa6fd404546d6ba84df)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Reserves.pm            |    7 ++++++-
 t/db_dependent/Reserves.t |   17 ++++++++++++++++-
 2 files changed, 22 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository