[koha-commits] main Koha release repository branch master updated. v3.14.00-378-gd567733

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  d567733f2325817cca694c437c01a9e1c669f368 (commit)
      from  1a5da08342182c739f2f5b790038c6ff04c748ea (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d567733f2325817cca694c437c01a9e1c669f368
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Wed Jan 29 12:52:51 2014 -0500

    Bug 11534: fix bug that made it impossible to remove instructors from a course
    
    In some cases clicking the "remove" link to remove a course instructor
    when editing a course reserves course doesn't work. I suspect this is
    caused by leading zeroes in the card number. This patch refactors the
    relevant function to fix the problem and to remove inline JavaScript
    from generated markup.
    
    Other changes:
    
    - Make the "Remove" text translatable
    - Re-order the first name and last name when added by JavaScript to
    match the template's "surname, firstname" order.
    
    To test:
    
    1. If necessary, create or modify a patron to have a card number
       with leading zeroes.
    2. Go to Course reserves and add or edit a course.
    3. If you are editing a course and there are existing instructors, click
       the "remove" link. Nothing will happen.
    4. Perform a patron search and choose one of the results. The name
       should be added to the list of instructors in the format "surname,
       firstname."
    5. Click the "remove" link next to the patron name which was just added.
       Nothing will happen.
    6. Apply the patch and repeat step 4. The "remove" link should work.
    7. Add an instructor and save the course reserve. Repeat steps 2 and 3.
       The "remove" link should now work.
    
    To test the translation fix, after applying the patch run "translate
    update [language code]" and confirm that the "Remove" string is listed
    in the updated po file for course_reserves/course.tt.
    
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 .../prog/en/modules/course_reserves/course.tt      |   31 +++++++++++++-------
 1 file changed, 20 insertions(+), 11 deletions(-)


hooks/post-receive
-- 
main Koha release repository