[koha-commits] main Koha release repository branch master updated. v3.16.00-190-gd0d54d8

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  d0d54d8a929f6b3813ab3eac48b796ae05c82dfa (commit)
      from  0162453a1cf20f5037bdda1cdeb662283f05f5f0 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d0d54d8a929f6b3813ab3eac48b796ae05c82dfa
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Thu Jun 19 10:17:53 2014 +0200

    Bug 12451 - circulation rule cant be edited if itemtype contains a space character
    
    When an itemtype description contains a space character like " Book"
    (often used to set this itemtype as first in sorted lists), the edition
    of an existing circulation rule does not work, it selects the default
    itemtype. Same for patron category.
    
    It's because the JavaScript code performs a trim on value existing in
    table itm = itm.replace(/^\s*|\s*$/g,''); This patch adds trim on select
    options in editing line.
    
    Test plan :
    - Create an itemtype with a leading or trailling space in description :
      ie " Book"
    - Go to cgi-bin/koha/admin/smart-rules.pl
    - Create a rule with this itemtype, Unit=hours and Hard due date=Exactly
      on 31/12/2015 (any date)
    - Click on Edit on this rule line
      => Without this patch, the default itemtype is selected in edition
         line
      => With this patch, the correct itemtype is selected in edition line
    
    Check others selects are ok :
      - Create a rule with Unit=hours and Hard due date=Exactly on
        31/12/2015 (any date)
      - Click on Edit on this rule line
        => The correct options are selected
    Same tests with a patron category containing a leading or trailling space in description
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-----------------------------------------------------------------------

Summary of changes:
 koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)


hooks/post-receive
-- 
main Koha release repository