[koha-commits] main Koha release repository branch master updated. v3.16.00-206-gf001cc3

Thu Jul 3 19:41:35 CEST 2014

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  f001cc32a3ce42262b37c6c22fe8ecbd0c32f966 (commit)
       via  a3c9c4b11db62bee5d98624528c524a09a0b93b0 (commit)
       via  a66eb6e86d58bad633020cbd02b147952ff2da31 (commit)
       via  63789fc09531667a313f0433800c2637a0642821 (commit)
      from  9657a2c6dc92516963ffa960b7d561cdcc2dc5e8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit f001cc32a3ce42262b37c6c22fe8ecbd0c32f966
Author: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Date:   Fri May 2 18:38:20 2014 -0300

    Bug 11638: Remove HTML from addbiblio.pl

    This patch extracts variables with HTML from addbiblio.pl
    and an instance of CGI::scrolling_list

    As it changes how MARC editor show input fields, I prefer
    not add patches for other cases mentioned on Comment #1

    To test:
    1. Verify there are no regressions on MARC editor
    Add/Edit records, modify values
    2. Update translation file for a language,
    check new string 'Tag editor'

    About the error message on error when deleting biblio,
    it must be localized but the script is not trying to
    use a template file, only prints a basic html and aborts.
    Perhaps a way of handling errors more gracefully is needed,
    but again it need to be solved on it's own bug.

    Updated test plan

    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit a3c9c4b11db62bee5d98624528c524a09a0b93b0
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Thu Jul 3 14:36:25 2014 -0300

    Bug 12482: (QA followup) coding guidelines for hashrefs

    As of the public coding guidelines, $$variable{key} usage is discouraged. $variable->{key} should be used instead.

    Btw, honour the "FIXME - Bug 2505" line :-D

    Regards
    To+

    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit a66eb6e86d58bad633020cbd02b147952ff2da31
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Wed Jul 2 14:49:01 2014 -0400

    Bug 12482 [QA Followup]

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 63789fc09531667a313f0433800c2637a0642821
Author: Yohann Dufour <dufour.yohann at gmail.com>
Date:   Thu Jun 26 14:28:58 2014 +0200

    Bug 12482: removing the use of the module C4::SQLHelper.pm, it is replaced by DBIx::Class

    This patch includes:
    - removing the use of subroutines InsertInTable, UpdateInTable, SearchInTable replaced by subroutines of DBIx::Class in the subroutines AddBudget, ModBudget, GetBudgets, AddBudgetPeriods, ModBudgetPeriod and GetBudgetPeriods and admin/aqbudgetperiods.pl
    - removing old database fields in OrderFromSubscription.t, Bookseller.t, Budgets.t, Serials.t, Serials_2.t
    - improvement of unit tests in t/db_dependent/Budgets.t
    - adaptation of calls to the subroutines AddBudget, ModBudget, GetBudgets, AddBudgetPeriods, ModBudgetPeriod and GetBudgetPeriods in order to match with the use of DBIx::Class

    Test plan:

    1) Execute the UT of all of files wich uses AddBudget, ModBudget, GetBudgets, AddBudgetPeriods, ModBudgetPeriod or GetBudgetPeriods by launching the command :
    prove t/Budgets/ t/Budgets.t t/db_dependent/Budgets.t t/db_dependent/Acquisition.t t/db_dependent/Acquisition/ t/db_dependent/Bookseller.t t/db_dependent/Serials.t t/db_dependent/Serials_2.t

    2) The result has to be a success :
    t/Budgets/CanUserModifyBudget.t ........................... ok
    t/Budgets/CanUserUseBudget.t .............................. ok
    t/Budgets.t ............................................... ok
    t/db_dependent/Budgets.t .................................. ok
    t/db_dependent/Acquisition.t .............................. ok
    t/db_dependent/Acquisition/GetBasketsInfosByBookseller.t .. ok
    t/db_dependent/Acquisition/GetOrdersByBiblionumber.t ...... ok
    t/db_dependent/Acquisition/Invoices.t ..................... ok
    t/db_dependent/Acquisition/OrderFromSubscription.t ........ ok
    t/db_dependent/Acquisition/TransferOrder.t ................ 1/11 # Transfering order to basket2
    t/db_dependent/Acquisition/TransferOrder.t ................ ok
    t/db_dependent/Acquisition/close_reopen_basket.t .......... ok
    t/db_dependent/Bookseller.t ............................... 16/72 WARNING: GetBooksellerWithLateOrders is called with a negative value at /home/yohann/koha/C4/Bookseller.pm line 135.
    t/db_dependent/Bookseller.t ............................... ok
    t/db_dependent/Serials.t .................................. ok
    t/db_dependent/Serials_2.t ................................ ok
    All tests successful.
    Files=14, Tests=571, 22 wallclock secs ( 0.17 usr  0.03 sys + 20.26 cusr  1.10 csys = 21.56 CPU)
    Result: PASS

    3) Go on the page admin/aqbudgetperiods.pl : Koha Administration > Budgets
    4) Click on the button "New Budget" and record a new budget with a "nonzero amount" and "make budget active"
    5) Click on the button "New Budget" and record another budget without "make budget active"
    6) Verify there is the firt budget displayed in "Active budgets" and the second budget in "Inactive budgets"
    7) Edit a budget and verify the new values are updated
    8) Click on the budget active name in order to go on the page admin/aqbudgets.pl
    9) Click on the button "New fund for ..." and record a new fund
    10) Click on the button "Edit" then "Duplicate budget ..." in order to duplicate the budget
    11) Verify there are two budgets in "Active Budgets" and one in "Inactive Budgets"
    12) Click on "Funds" in the menu and verify there are two identical funds and each is associated to a different budget.

    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Budgets.pm                                      |   44 +++-
 admin/aqbudgetperiods.pl                           |   45 ++--
 admin/aqbudgets.pl                                 |   20 +-
 cataloguing/addbiblio.pl                           |  168 ++++++------
 .../prog/en/modules/cataloguing/addbiblio.tt       |   28 +-
 t/db_dependent/Acquisition/OrderFromSubscription.t |    8 +-
 t/db_dependent/Bookseller.t                        |    8 +-
 t/db_dependent/Budgets.t                           |  270 +++++++++++---------
 t/db_dependent/Serials.t                           |    8 +-
 t/db_dependent/Serials_2.t                         |    8 +-
 10 files changed, 336 insertions(+), 271 deletions(-)

hooks/post-receive
-- 
main Koha release repository