[koha-commits] main Koha release repository branch master updated. v3.16.00-214-g47de926

Mon Jul 7 14:50:36 CEST 2014

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  47de926463c7f50cde887dfa36895a125a09b7c8 (commit)
       via  f187d9d9e7b2e399b70b70c3aa9c229a5010d294 (commit)
       via  5cfb693a826c8497cfb7c1608ff02530c29f7e7d (commit)
       via  82e8a7a155807f50edae4e5f2b46791479c9b92d (commit)
       via  091a74de4c0fb6b0ff948eb716808dfc009a1207 (commit)
       via  e0bba7040f058135e7008410fd99653c059e96fe (commit)
       via  b140b8cc0841494ac03fcb3c5faf83e1678d2bd2 (commit)
      from  16250f76d2bbdbee0cb8d6115a80c182e84e94e4 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 47de926463c7f50cde887dfa36895a125a09b7c8
Author: Yohann Dufour <dufour.yohann at gmail.com>
Date:   Wed Jul 2 09:13:44 2014 +0200

    Bug 12499: adding units tests for C4::Letters

    The tests for the subroutines : GetMessageTransportType, EnqueueLetter, SendQueuedMessages, GetQueuedMessages, GetLetters, getletter, addalert, getalert, delalert and GetPreparedLetter of the module C4::Letters have been added.

    Test plan:
    1) Apply the patch
    2) Execute the unit tests by launching :
    prove t/db_dependent/Letters.t
    3) The result has to be a success without error or warning :
    t/db_dependent/Letters.t .. ok
    All tests successful.
    Files=1, Tests=45,  2 wallclock secs ( 0.04 usr  0.01 sys +  1.44 cusr  0.08 csys =  1.57 CPU)
    Result: PASS

    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    All test pass, no errors.

    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit f187d9d9e7b2e399b70b70c3aa9c229a5010d294
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Mon Jun 2 11:14:11 2014 -0300

    Bug 12151: Remove uses of smartmatch operator from Koha/Solr/QueryBuilder.pm

    Just that.

    Regards
    To+

    Sponsored-by: Universidad Nacional de Cordoba

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Passes QA script and tests.
    Could only verify by reading the code.

    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 5cfb693a826c8497cfb7c1608ff02530c29f7e7d
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Mon Jun 2 11:30:48 2014 -0300

    Bug 12151: Remove use of smartmatch operator in tools/batchMod.pl

    The '~~' smartmatch operator is used to compare MARC::Field->subfield(code)
    (i.e. a string) and the text element of each MARC::Field->subfields() which
    is also plain text.

    Substituting '~~' for 'eq' should be harmless then.

    Regards
    To+

    Sponsored-by: Universidad Nacional de Cordoba

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Passes QA script and tests.
    Tested batch modification of items, no problems found.

    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 82e8a7a155807f50edae4e5f2b46791479c9b92d
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Sat May 31 00:30:32 2014 -0300

    Bug 12151: Remove uses of smartmatch operator in report scripts

    This patch removes the use of smartmatch operators in report scripts.

    Regards
    To+

    Sponsored-by: Universidad Nacional de Cordoba

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Passes QA script and tests.
    Acquisition and Patron statistics wizard tested, no regressions found.

    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 091a74de4c0fb6b0ff948eb716808dfc009a1207
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Fri May 30 20:54:10 2014 -0300

    Bug 12151: Remove uses of smartmatch operator in Search.pm and opac-search.pl

    This patch removes the use of smartmatch operators in the search code.

    Regards
    To+

    Edit: this revision uses 'grep' instead of Lists::MoreUtils::any

    Sponsored-by: Universidad Nacional de Cordoba

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Passes all tests and QA script.
    Tested search, no problems found.

    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit e0bba7040f058135e7008410fd99653c059e96fe
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date:   Sun Jul 6 21:00:40 2014 +0200

    Bug 12409: Follow up - Reflect from hash to array in comments

    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit b140b8cc0841494ac03fcb3c5faf83e1678d2bd2
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Thu Jun 12 11:06:58 2014 +0200

    Bug 12409: Fix fields order on exporting to bibtex

    The C4::Record::marc2bibtex subroutine supposes hashref keys are sorted
    which is wrong with perl 5.18

    Note that the t/db_dependent/Record.t fails without this patch.

    Test plan (for perl >= 5.18 only):
    1/ prove t/db_dependent/Record.t should return green
    2/ Try to export a record to bibtex and verify the order is correct
    (should be author, title, year, published, etc.).

    http://bugs.koha-community.org/show_bug.cgi?id=12409

    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

    Wrong Bug number on heading.
    Work as described, test pass, no koha-qa errors.

    The problem is to think that a hash returns
    keys in a particular order, that's not true
    and no matter which perl version.

    Code as was left is... misleading.
    Comments talks about a hash, which is no more.
    On array asignment "a => b" is equivalent to "a, b",
    but the former is usually used on hashes, so a
    replacement of '=>' by ',' could clarify what are we storing.

    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Fixing the comments in a follow-up patch.
    Tests pass now without problems and records export ok.

    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Record.pm                           |   91 +++++++-------
 C4/Search.pm                           |    2 +-
 Koha/SearchEngine/Solr/QueryBuilder.pm |   16 +--
 opac/opac-search.pl                    |   15 +--
 reports/acquisitions_stats.pl          |  101 ++++++++--------
 reports/borrowers_stats.pl             |   60 +++++-----
 t/db_dependent/Letters.t               |  202 +++++++++++++++++++++++++++++---
 tools/batchMod.pl                      |    2 +-
 8 files changed, 330 insertions(+), 159 deletions(-)

hooks/post-receive
-- 
main Koha release repository