[koha-commits] main Koha release repository branch master updated. v3.16.00-238-gc3c7068

Git repo owner gitmaster at git.koha-community.org
Mon Jul 14 13:32:38 CEST 2014


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  c3c7068709177408af59fb4e9538f623ba945a18 (commit)
       via  61dc0ab223aa2a3e83bf980cd5616a325e03871a (commit)
       via  e1e0ac329c6fff33b47254a415c99e8048cebd91 (commit)
       via  ab3bce193f823f426a36e348b00153888c61f281 (commit)
       via  99e25ff30dd574ac2dc13e3e73cdccee6f44ce1f (commit)
      from  5e5c0380700565ce1f75a389473ae71910fcb452 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c3c7068709177408af59fb4e9538f623ba945a18
Author: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Date:   Sun Jul 6 20:21:43 2014 -0300

    Bug 12534 - PROG/CCSR deprecation: Make getlanguages() theme independent for opac
    
    This patch removes a reference to prog theme on getlanguages()
    when ENV var HTTP_ACCEPT_LANGUAGE is checked.
    
    Changed to use sysprefs to find theme for opac and intranet
    
    To test:
    1) Apply the patch
    2) Translate for a couple of languages: de-DE, fr-FR, es-ES, etc
    3) Enable those languages for OPAC on I18N prefs
    4) Using Firefox, clean all history/cookies
    5) Change variable intl.accept_languages (will do several times)
     a) got to about:config
     b) search 'lang'
     c) look for the variable, double click, change to 'de-DE'
    6) Go to opac page, must load in german
    7) Repeat for each translated lang: clean > change val > reload opac
       On each case opac must load on configured language
    8) Just to test, set variable on untranslated lang, opac page
    must load on first value of list of enabled languages
    9) prove t/Languages.t
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 61dc0ab223aa2a3e83bf980cd5616a325e03871a
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Mon Jul 14 08:56:22 2014 -0300

    Bug 12470: (followup) License statement missing
    
    Adds the license statement to the new files.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit e1e0ac329c6fff33b47254a415c99e8048cebd91
Author: Yohann Dufour <dufour.yohann at gmail.com>
Date:   Tue Jun 24 14:27:21 2014 +0200

    Bug 12470: adding unit tests for the routines CheckValidBarCode and CheckIfIssuedToPatron of the module C4::Circulation.pm
    
    The routines CheckValidBarcode and CheckIfIssuedToPatron were not tested
    
    Test plan:
    1/ Apply the patch
    2/ Execute : prove t/db_dependent/Circulation/CheckValidBarcode.t t/db_dependent/Circulation/CheckIfIssuedToPatron.t
    3/ The result of the command has to be a success without error or warning :
    t/db_dependent/Circulation/CheckValidBarcode.t ...... ok
    t/db_dependent/Circulation/CheckIfIssuedToPatron.t .. ok
    All tests successful.
    Files=2, Tests=32,  3 wallclock secs ( 0.04 usr  0.01 sys +  2.88 cusr  0.17 csys =  3.10 CPU)
    Result: PASS
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Patches squashed
    Tests pass, no koha-qa errors
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Tests pass using sample data provided with Koha
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit ab3bce193f823f426a36e348b00153888c61f281
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Wed Jul 2 09:10:33 2014 -0400

    Bug 12517 - Download and send list popups broken in bootstrap OPAC
    
    A JavaScript error prevents the download list and send list links in the
    bootstrap OPAC from functioning correctly. A variable declaration was
    removed from basket.js during the creation of the theme but
    opac-shelves.tt was not changed accordingly. This patch corrects it.
    
    To test, view an existing shelf in the bootstrap OPAC and test the
    "download list" and "send list" links. They should each trigger popups
    without any errors.
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Popups pops again, no koha-qa errors
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 99e25ff30dd574ac2dc13e3e73cdccee6f44ce1f
Author: David Cook <dcook at prosentient.com.au>
Date:   Thu Jul 3 16:32:57 2014 +1000

    Bug 12522 - Fatal database error when viewing Holds for Bib with no Items
    
    This patch fixes some potential SQL syntax errors, which can cause
    fatal software errors in Koha when the environmental variable DEBUG
    is on.
    
    _TEST PLAN_
    
    Before applying:
    
    0) Ensure that you don't have "SetEnv DEBUG 1" in your Apache config
    1) Create a new bib record
    2) Click on the "Holds" tab before creating any items
    3) Note the message "Cannot place hold: this record has no
    items attached."
    
    4) Add "SetEnv DEBUG 1" to your Apache config
    5) Restart Apache
    6) Refresh your page
    7) Note the following Software Error: "DBD::mysql::st execute failed:
    You have an error in your SQL syntax; check the manual that
    corresponds to your MariaDB server version for the right syntax to
    use near ')' at line 3 at /koha/lib/C4/Koha.pm line 835.
    
    8) Apply the patch
    
    9) Refresh your page
    10) Note the message from Step 3
    
    Thorough tester:
    
    11) Remove "SetEnv DEBUG 1" from your Apache config, restart Apache,
    and refresh your page. You should see the message from Step 3.
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Error reproduced, patch fixes it.
    Tested following test plan, no koha-qa errors.
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Biblio.pm                                       |    8 +-
 C4/Items.pm                                        |    8 +-
 C4/Languages.pm                                    |    3 +-
 .../opac-tmpl/bootstrap/en/modules/opac-shelves.tt |    4 +-
 t/db_dependent/Circulation/CheckIfIssuedToPatron.t |  124 ++++++++++++++++++++
 t/db_dependent/Circulation/CheckValidBarcode.t     |   87 ++++++++++++++
 6 files changed, 225 insertions(+), 9 deletions(-)
 create mode 100644 t/db_dependent/Circulation/CheckIfIssuedToPatron.t
 create mode 100644 t/db_dependent/Circulation/CheckValidBarcode.t


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list