[koha-commits] main Koha release repository branch master updated. v3.16.00-253-g499ff36

Tue Jul 15 15:56:23 CEST 2014

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  499ff3618c4507619a84bd793727f51f5889e5b4 (commit)
       via  d9749756ca49dc5b6f65a3e1af877deae1161e2f (commit)
       via  7c8b152c3865b4713b37baf2b3d21da4d6e2bfa6 (commit)
       via  227dddc9c01730c9b09d5e7fff18c92679e39aeb (commit)
      from  abd6de7da1f5c33694fc4a29a4e7f7f6aa2c222e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 499ff3618c4507619a84bd793727f51f5889e5b4
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Thu May 15 12:24:57 2014 +0100

    Bug 12263: Fix startup issues blocking response to HUP

    If you do a kill -s HUP sipserver_pid the server process
    should restart its children.
    This was not happening although it was logging the commencement
    of the process.

    Removed traces of Exporter usage this was always incorrect
    this program inherits from Net::Server 'use base' to make inheritance
    clearer. Removed unnecessary begin block

    made file executable so it can run

    added a shebang line so OS knows to invoke perl to compile and run
    the file.

    I've removed the debug code dumping the config to STDOUT,
    it should not have gone into the production version.
    One of the first things this program does is close stdout etc and
    reopens the sip sockets to them. Assuming you can print to them other
    than as part of the sip dialogue is not always safe.

    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit d9749756ca49dc5b6f65a3e1af877deae1161e2f
Author: David Cook <dcook at prosentient.com.au>
Date:   Mon Jan 20 11:54:26 2014 +1100

    Bug 11575 - OPACBaseURL sometimes set by ENV variable and not system preference

    This patch changes how the OPACBaseURL parameter gets set in the subroutine
    get_template_and_user in Auth.pm.

    Currently, it's being set by the $ENV{'SERVER_NAME'} variable. In many
    cases, this will probably match the URL that the user uses to access a
    page. However, this causes problems with reverse proxies.

    There are ways to compensate for proxy servers (such as inspecting
    other variables set by the web server), but such a solution seems
    a bit convoluted...especially since we already use the system preference
    OPACBaseURL in many other parts of Koha.

    We probably shouldn't be passing OPACBaseURL from Auth.pm at all, and
    instead use the Koha TT plugin and using_https param to determine
    protocol. However, that's outside the scope of this bug/patch.

    This patch is just meant to fix an existing bug.

    I did leave the $ENV{'SERVER_NAME'} as a full back if OPACBaseURL isn't
    set, but that's it.

    _TEST PLAN_

    Before applying:

    1) Clear your OPACBaseURL preference
    2) Perform a search in the OPAC
    3) Click on or hover over the orange RSS icon
    4) Note that the URL used for the RSS links is either:
      a) The same URL you used to access Koha (no reverse proxy)
      b) The ServerName from your Koha apache conf which isn't the
      same URL you used to access Koha (reverse proxy)
    5) Add an OPACBaseURL that isn't the same as the actual OPAC URL
    6) Note that the OPACBaseURL system preference has no effect here

    After applying the patch:

    7) Refresh the page
    8) Note that the URL you see now is actually the OPACBaseURL system
    preference that you set
    9) Clear your OPACBaseURL system preference
    10) Refresh your search page
    11) Note that the URL has reverted back to the URL that you saw before
    (either the original Koha site URL or the Koha ServerName defined
    in Apache and not the URL of the proxy)

    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 7c8b152c3865b4713b37baf2b3d21da4d6e2bfa6
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Fri Jul 11 12:59:24 2014 -0400

    Bug 12377 [QA Followup] - Remove readonly from input

    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 227dddc9c01730c9b09d5e7fff18c92679e39aeb
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Oct 25 07:48:15 2012 -0400

    Bug 12377 - Add date pickers to serials-edit.pl

    There are two date fields when receiving serials on serials-edit.pl,
    these inputs should have a calendar widget like other date fields
    in Koha.

    Test Plan:
    1) Apply this patch
    2) Recieve a serial
    3) Note when clicking on the "Published on" or "Expected on" fields
       you will now have a calendar popup. Note you can still manually
       edit the date if you wish to.

    Signed-off-by: Aleisha <aleishaamohia at hotmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Auth.pm                                             |    8 ++++++--
 C4/SIP/SIPServer.pm                                    |   16 +++-------------
 .../prog/en/modules/serials/serials-edit.tt            |   11 +++++++----
 3 files changed, 16 insertions(+), 19 deletions(-)
 mode change 100644 => 100755 C4/SIP/SIPServer.pm

hooks/post-receive
-- 
main Koha release repository