[koha-commits] main Koha release repository branch master updated. v3.16.00-265-ge185aaf

Git repo owner gitmaster at git.koha-community.org
Mon Jul 21 23:25:53 CEST 2014


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  e185aaf19b1efeee342fc32a35323a0a9ea03a58 (commit)
      from  54efd3d17955bfd3a9623d7e7f7ac426786896f8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit e185aaf19b1efeee342fc32a35323a0a9ea03a58
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Wed Jul 2 12:50:54 2014 -0400

    Bug 12519 - Convert OPAC list download pop-up to modal dialog
    
    This patch changes the OPAC list download process so that the download
    link triggers a modal dialog instead of a pop-up window. This
    streamlines the process a little bit and makes it work better on mobile
    devices.
    
    The download list page has been altered so that it works better as a
    standalone page, as it might be seen if JavaScript is disabled. Simple
    form validation has been added to help prevent submission of the form
    without choosing a format.
    
    To test the virtualshelves system preference must be enabled.
    
    - View an existing list in the OPAC and click the "download list" link.
    - A modal dialog should be displayed with the download form.
    - Submitting the form without selecting a format should trigger either a
      browser-based form validation error (in HTML5-supporting browsers) or
      a JavaScript alert (if your browser doesn't support the "required"
      attribute.
    - Choosing a download format and submitting the form should close
      the dialog and trigger the correct download.
    - Clicking the "Cancel" link should close the dialog.
    
    Test with JavaScript disabled:
    
    - Clicking the "download list" link should take you to a page which
      contains the same form which appeared in the modal dialog.
    - Submitting the form without selecting a format should trigger either a
      browser-based form validation error (in HTML5-supporting browsers) or
      a JavaScript alert (if your browser doesn't support the "required"
      attribute..
    - Choosing a download format and submitting the form should result in
      the corect download.
    - Clicking the "Cancel" link should return you to the correct list.
    
    Signed-off-by: Aleisha <aleishaamohia at hotmail.com>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Passes QA script and tests, works as described.
    
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

-----------------------------------------------------------------------

Summary of changes:
 .../bootstrap/en/modules/opac-downloadshelf.tt     |  102 ++++++++++++++++----
 .../opac-tmpl/bootstrap/en/modules/opac-shelves.tt |   17 +++-
 opac/opac-downloadshelf.pl                         |   20 +++-
 3 files changed, 118 insertions(+), 21 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list